mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: mchehab@infradead.org
To: linux-kernel@vger.kernel.org
Cc: linux-dvb-maintainer@linuxtv.org,
	Jean Delvare <khali@linux-fr.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [PATCH 7/8] V4L/DVB (4817): Fix uses of "&&" where "&" was intended
Date: Mon, 13 Nov 2006 10:18:44 -0200	[thread overview]
Message-ID: <20061113121844.PS4890100007@infradead.org> (raw)
In-Reply-To: <20061113121504.PS7687690000@infradead.org>


From: Jean Delvare <khali@linux-fr.org>

Fix uses of "&&" where "&" was intended in bttv-cards.c and tveeprom.c

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

 drivers/media/video/bt8xx/bttv-cards.c |    2 +-
 drivers/media/video/tveeprom.c         |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/bt8xx/bttv-cards.c b/drivers/media/video/bt8xx/bttv-cards.c
index a84903e..21ebe8f 100644
--- a/drivers/media/video/bt8xx/bttv-cards.c
+++ b/drivers/media/video/bt8xx/bttv-cards.c
@@ -4001,7 +4001,7 @@ static void __devinit init_PXC200(struct
  *      - sleep 1ms
  *      - write 0x0E
  *     read from GPIO_DATA into buf (uint_32)
- *      - if ( buf>>18 & 0x01 ) || ( buf>>19 && 0x01 != 0 )
+ *      - if ( buf>>18 & 0x01 ) || ( buf>>19 & 0x01 != 0 )
  *                error. ERROR_CPLD_Check_Failed.
  */
 /* ----------------------------------------------------------------------- */
diff --git a/drivers/media/video/tveeprom.c b/drivers/media/video/tveeprom.c
index e6baaee..6b9ef73 100644
--- a/drivers/media/video/tveeprom.c
+++ b/drivers/media/video/tveeprom.c
@@ -468,7 +468,7 @@ void tveeprom_hauppauge_analog(struct i2
 				(eeprom_data[i+6] << 8) +
 				(eeprom_data[i+7] << 16);
 
-				if ( (eeprom_data[i + 8] && 0xf0) &&
+				if ( (eeprom_data[i + 8] & 0xf0) &&
 					(tvee->serial_number < 0xffffff) ) {
 					tvee->MAC_address[0] = 0x00;
 					tvee->MAC_address[1] = 0x0D;


  parent reply	other threads:[~2006-11-13 12:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-13 12:15 [PATCH 0/8] V4L/DVB fixes mchehab
2006-11-13 12:18 ` [PATCH 3/8] V4L/DVB (4804): Fix missing i2c dependency for saa7110 mchehab
2006-11-13 12:18 ` [PATCH 1/8] V4L/DVB (4795): Tda826x: use correct max frequency mchehab
2006-11-13 12:18 ` [PATCH 2/8] V4L/DVB (4802): Cx88: fix remote control on WinFast 2000XP Expert mchehab
2006-11-13 12:18 ` mchehab [this message]
2006-11-13 12:18 ` [PATCH 5/8] V4L/DVB (4815): Remote support for Avermedia A16AR mchehab
2006-11-13 12:18 ` [PATCH 4/8] V4L/DVB (4814): Remote support for Avermedia 777 mchehab
2006-11-13 12:18 ` [PATCH 8/8] V4L/DVB (4818): Flexcop-usb: fix debug printk mchehab
2006-11-13 12:18 ` [PATCH 6/8] V4L/DVB (4816): Change tuner type for Avermedia A16AR mchehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061113121844.PS4890100007@infradead.org \
    --to=mchehab@infradead.org \
    --cc=khali@linux-fr.org \
    --cc=linux-dvb-maintainer@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®