mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: mchehab@infradead.org
To: linux-kernel@vger.kernel.org
Cc: linux-dvb-maintainer@linuxtv.org,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [PATCH 8/8] V4L/DVB (4818): Flexcop-usb: fix debug printk
Date: Mon, 13 Nov 2006 10:18:44 -0200	[thread overview]
Message-ID: <20061113121844.PS6450200008@infradead.org> (raw)
In-Reply-To: <20061113121504.PS7687690000@infradead.org>


From: Alexey Dobriyan <adobriyan@gmail.com>

.. fix debug printk. Why, oh why, one would want to do
	(u16 & 0xff) << 8
and print it with %02x format?
Acked-by: Patrick Boettcher <pb@linuxtv.org>

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

 drivers/media/dvb/b2c2/flexcop-usb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/dvb/b2c2/flexcop-usb.c b/drivers/media/dvb/b2c2/flexcop-usb.c
index 2853ea1..87fb75f 100644
--- a/drivers/media/dvb/b2c2/flexcop-usb.c
+++ b/drivers/media/dvb/b2c2/flexcop-usb.c
@@ -246,7 +246,7 @@ static int flexcop_usb_i2c_req(struct fl
 	wIndex = (chipaddr << 8 ) | addr;
 
 	deb_i2c("i2c %2d: %02x %02x %02x %02x %02x %02x\n",func,request_type,req,
-			((wValue && 0xff) << 8),wValue >> 8,((wIndex && 0xff) << 8),wIndex >> 8);
+		wValue & 0xff, wValue >> 8, wIndex & 0xff, wIndex >> 8);
 
 	len = usb_control_msg(fc_usb->udev,pipe,
 			req,


  parent reply	other threads:[~2006-11-13 12:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-13 12:15 [PATCH 0/8] V4L/DVB fixes mchehab
2006-11-13 12:18 ` [PATCH 2/8] V4L/DVB (4802): Cx88: fix remote control on WinFast 2000XP Expert mchehab
2006-11-13 12:18 ` [PATCH 1/8] V4L/DVB (4795): Tda826x: use correct max frequency mchehab
2006-11-13 12:18 ` [PATCH 3/8] V4L/DVB (4804): Fix missing i2c dependency for saa7110 mchehab
2006-11-13 12:18 ` [PATCH 6/8] V4L/DVB (4816): Change tuner type for Avermedia A16AR mchehab
2006-11-13 12:18 ` mchehab [this message]
2006-11-13 12:18 ` [PATCH 4/8] V4L/DVB (4814): Remote support for Avermedia 777 mchehab
2006-11-13 12:18 ` [PATCH 5/8] V4L/DVB (4815): Remote support for Avermedia A16AR mchehab
2006-11-13 12:18 ` [PATCH 7/8] V4L/DVB (4817): Fix uses of "&&" where "&" was intended mchehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061113121844.PS6450200008@infradead.org \
    --to=mchehab@infradead.org \
    --cc=adobriyan@gmail.com \
    --cc=linux-dvb-maintainer@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®