* [PATCH] eCryptfs: dput() lower d_parent on rename
@ 2006-11-14 19:21 Michael Halcrow
0 siblings, 0 replies; only message in thread
From: Michael Halcrow @ 2006-11-14 19:21 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
On rename, for both the old and new lower dentry objects, eCryptfs is
missing a dput on the lower parent directory dentry. This patch will
prevent the BUG() at fs/dcache.c:613 from being hit after renaming a
file inside eCryptfs and then doing a umount on the lower filesystem.
Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com>
---
fs/ecryptfs/inode.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
ad6bdd754bf12f926bf6b2e528d085177bce9def
diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index fc0f624..dfcc684 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -631,6 +631,8 @@ ecryptfs_rename(struct inode *old_dir, s
ecryptfs_copy_attr_all(old_dir, lower_old_dir_dentry->d_inode);
out_lock:
unlock_rename(lower_old_dir_dentry, lower_new_dir_dentry);
+ dput(lower_new_dentry->d_parent);
+ dput(lower_old_dentry->d_parent);
dput(lower_new_dentry);
dput(lower_old_dentry);
return rc;
--
1.3.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-11-14 19:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-11-14 19:21 [PATCH] eCryptfs: dput() lower d_parent on rename Michael Halcrow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome