mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: akpm@osdl.org
Cc: Peter Williams <pwil3058@bigpond.net.au>,
	linux-kernel@vger.kernel.org,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Christoph Lameter <clameter@sgi.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	"Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	Ingo Molnar <mingo@elte.hu>,
	"Siddha, Suresh B" <suresh.b.siddha@intel.com>
Subject: [PATCH 2/8] Remove staggering of load balancing
Date: Tue, 14 Nov 2006 12:33:06 -0800 (PST)	[thread overview]
Message-ID: <20061114203306.12761.54020.sendpatchset@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20061114203256.12761.33911.sendpatchset@schroedinger.engr.sgi.com>

Remove load staggering.

Timer interrupts already are staggered. We do not need an additional
layer of time staggering for short load balancing actions that take a
reasonably small portion of the time slice.

For load balancing on large sched_domains we will add a serialization
later that avoids concurrent load balance operations and thus has
the same effect as load staggering.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.19-rc5-mm1/kernel/sched.c
===================================================================
--- linux-2.6.19-rc5-mm1.orig/kernel/sched.c	2006-11-10 22:47:56.305271903 -0600
+++ linux-2.6.19-rc5-mm1/kernel/sched.c	2006-11-10 22:48:09.002647332 -0600
@@ -2844,16 +2844,10 @@ static void active_load_balance(struct r
  * Balancing parameters are set up in arch_init_sched_domains.
  */
 
-/* Don't have all balancing operations going off at once: */
-static inline unsigned long cpu_offset(int cpu)
-{
-	return jiffies + cpu * HZ / NR_CPUS;
-}
-
 static void
 rebalance_tick(int this_cpu, struct rq *this_rq, enum idle_type idle)
 {
-	unsigned long this_load, interval, j = cpu_offset(this_cpu);
+	unsigned long this_load, interval;
 	struct sched_domain *sd;
 	int i, scale;
 
@@ -2888,7 +2882,7 @@ rebalance_tick(int this_cpu, struct rq *
 		if (unlikely(!interval))
 			interval = 1;
 
-		if (j - sd->last_balance >= interval) {
+		if (jiffies - sd->last_balance >= interval) {
 			if (load_balance(this_cpu, this_rq, sd, idle)) {
 				/*
 				 * We've pulled tasks over so either we're no

  parent reply	other threads:[~2006-11-14 20:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-14 20:32 [PATCH 0/8] sched_domain balancing via softirq V4 Christoph Lameter
2006-11-14 20:33 ` [PATCH 1/8] Avoid taking rq lock in wake_priority_sleeper Christoph Lameter
2006-11-14 20:33 ` Christoph Lameter [this message]
2006-11-14 20:33 ` [PATCH 3/8] Disable interrupts for locking in load_balance() Christoph Lameter
2006-11-14 20:33 ` [PATCH 4/8] Extract load calculation from rebalance_tick Christoph Lameter
2006-11-14 20:33 ` [PATCH 5/8] Move idle status calculation into rebalance_tick() Christoph Lameter
2006-11-14 20:33 ` [PATCH 6/8] Use softirq for load balancing Christoph Lameter
2006-11-14 20:33 ` [PATCH 7/8] Call tasklet less frequently Christoph Lameter
2006-11-14 20:33 ` [PATCH 8/8] Add option to serialize load balancing Christoph Lameter
2006-11-14 20:33 ` [DEBUG] Add a few scheduler event counters Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061114203306.12761.54020.sendpatchset@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@osdl.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=pwil3058@bigpond.net.au \
    --cc=suresh.b.siddha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome