From: Dmitry Torokhov <dtor@insightbb.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
jesper.juhl@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???
Date: Thu, 16 Nov 2006 22:46:18 -0500 [thread overview]
Message-ID: <200611162246.21018.dtor@insightbb.com> (raw)
In-Reply-To: <E1GkrjY-0004Dt-00@gondolin.me.apana.org.au>
On Thursday 16 November 2006 19:37, Herbert Xu wrote:
> David Miller <davem@davemloft.net> wrote:
> >
> > I'm very happy to accept a patch which assert's this using BUG()
> > checks :-)
>
> A BUG() won't be necessary because the NULL pointer dereferences will
> OOPS anyway.
>
BUG()s there would be a mechanism to document invariants so next time
someone is looking at the code there are no questions.
--
Dmitry
next prev parent reply other threads:[~2006-11-17 4:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 22:34 Jesper Juhl
2006-11-16 23:47 ` David Miller
2006-11-17 0:37 ` Herbert Xu
2006-11-17 3:46 ` Dmitry Torokhov [this message]
2006-11-17 5:28 ` Herbert Xu
2006-11-17 0:22 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611162246.21018.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®