From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Nigel Cunningham <ncunningham@linuxmail.org>,
Andrew Morton <akpm@osdl.org>, Pavel Machek <pavel@ucw.cz>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] swsusp: Fix labels
Date: Wed, 22 Nov 2006 23:50:18 +0100 [thread overview]
Message-ID: <200611222350.19243.rjw@sisk.pl> (raw)
In-Reply-To: <20061122143241.6b1a34ac.randy.dunlap@oracle.com>
On Wednesday, 22 November 2006 23:32, Randy Dunlap wrote:
> On Sun, 19 Nov 2006 00:25:06 +0100 Rafael J. Wysocki wrote:
>
> > On Sunday, 19 November 2006 00:06, Nigel Cunningham wrote:
> > > Hi.
> > >
> > > On Sat, 2006-11-18 at 23:51 +0100, Rafael J. Wysocki wrote:
> > > > Move all labels in the swsusp code to the second column, so that they won't
> > > > fool diff -p.
> > >
> > > This sounds like working around brokenness in diff -p. Should/could a
> > > patch be submitted to the diff maintainer instead?
> >
> > No. This feature of diff is actually documented.
> >
> > There was a discussion on LKML about it some time ago and the patch follows
> > the conclusion.
>
> There was discussion, and then both Jesper and I tried to
> reproduce the problem with diff and could not do so.
> Maybe it has already been fixed. (?)
Well, I'm not sure.
Greetings,
Rafael
--
You never change things by fighting the existing reality.
R. Buckminster Fuller
next prev parent reply other threads:[~2006-11-22 22:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-18 22:35 [PATCH 0/4] swsusp cleanups Rafael J. Wysocki
2006-11-18 22:47 ` [PATCH 1/4] swsusp: Untangle thaw_processes Rafael J. Wysocki
2006-11-18 23:03 ` Nigel Cunningham
2006-11-19 2:04 ` Pavel Machek
2006-11-19 12:01 ` Rafael J. Wysocki
2006-11-19 21:16 ` Pavel Machek
2006-11-18 22:47 ` [PATCH 2/4] swsusp: Untangle freeze_processes Rafael J. Wysocki
2006-11-19 2:09 ` Pavel Machek
2006-11-19 12:05 ` Rafael J. Wysocki
2006-11-19 21:17 ` Pavel Machek
2006-11-18 22:48 ` [PATCH 3/4] swsusp: Fix coding style in suspend.c Rafael J. Wysocki
2006-11-19 2:05 ` Pavel Machek
2006-11-18 22:51 ` [PATCH 4/4] swsusp: Fix labels Rafael J. Wysocki
2006-11-18 23:06 ` Nigel Cunningham
2006-11-18 23:25 ` Rafael J. Wysocki
2006-11-22 22:32 ` Randy Dunlap
2006-11-22 22:50 ` Rafael J. Wysocki [this message]
2006-11-19 1:46 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611222350.19243.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
--cc=pavel@ucw.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome