From: Alan <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: git-commits-head@vger.kernel.org
Subject: Re: PCI: Let PCI_MULTITHREAD_PROBE not be broken
Date: Sat, 2 Dec 2006 11:30:24 +0000 [thread overview]
Message-ID: <20061202113024.79e3330f@localhost.localdomain> (raw)
In-Reply-To: <200612020059.kB20xi2b003537@hera.kernel.org>
On Sat, 2 Dec 2006 00:59:44 GMT
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> @@ -19,7 +19,7 @@ config PCI_MSI
>
> config PCI_MULTITHREAD_PROBE
> bool "PCI Multi-threaded probe (EXPERIMENTAL)"
> - depends on PCI && EXPERIMENTAL && BROKEN
> + depends on PCI && EXPERIMENTAL
> help
NAK.
It is broken as it breaks init time ordering relied upon by many
drivers for same probing and it breaks existing drive assumptions that
the probe is single threaded and therefore unlocked.
At the very least it needs
&& !IDE && !WATCHDOG && !ATA
and probably far more.
This should not be enabled or even in the upstream tree until the
ordering problem is fixed and the submitter has done a review and fix of
all the locking.
Alan
parent reply other threads:[~2006-12-02 11:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200612020059.kB20xi2b003537@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061202113024.79e3330f@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=git-commits-head@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®