mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: PCI: Let PCI_MULTITHREAD_PROBE not be broken
       [not found] <200612020059.kB20xi2b003537@hera.kernel.org>
@ 2006-12-02 11:30 ` Alan
  0 siblings, 0 replies; only message in thread
From: Alan @ 2006-12-02 11:30 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: git-commits-head

On Sat, 2 Dec 2006 00:59:44 GMT
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> @@ -19,7 +19,7 @@ config PCI_MSI
>  
>  config PCI_MULTITHREAD_PROBE
>  	bool "PCI Multi-threaded probe (EXPERIMENTAL)"
> -	depends on PCI && EXPERIMENTAL && BROKEN
> +	depends on PCI && EXPERIMENTAL
>  	help

NAK. 

It is broken as it breaks init time ordering relied upon by many
drivers for same probing and it breaks existing drive assumptions that
the probe is single threaded and therefore unlocked.

At the very least it needs

	&& !IDE && !WATCHDOG && !ATA

and probably far more.

This should not be enabled or even in the upstream tree until the
ordering problem is fixed and the submitter has done a review and fix of
all the locking.

Alan


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-12-02 11:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <200612020059.kB20xi2b003537@hera.kernel.org>
2006-12-02 11:30 ` PCI: Let PCI_MULTITHREAD_PROBE not be broken Alan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®