From: Olivier Galibert <galibert@pobox.com>
To: Andi Kleen <ak@suse.de>,
linux-pci@atrey.karlin.mff.cuni.cz,
"Hack inc." <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>,
Muli Ben-Yehuda <muli@il.ibm.com>
Subject: [PATCH 2/5] PCI MMConfig: Only call unreachable_devices() when type 1 is available.
Date: Thu, 7 Dec 2006 19:29:40 +0100 [thread overview]
Message-ID: <20061207182940.GB73583@dspnet.fr.eu.org> (raw)
In-Reply-To: <20061207181726.GA69863@dspnet.fr.eu.org>
unreachable_devices compares between the results of pci configuration
accesses through type1 and mmconfig, so it should be called only if
type1 actually works in the first place.
Signed-off-by: Olivier Galibert <galibert@pobox.com>
---
arch/i386/pci/mmconfig-shared.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/i386/pci/mmconfig-shared.c b/arch/i386/pci/mmconfig-shared.c
index b3ab210..7b19639 100644
--- a/arch/i386/pci/mmconfig-shared.c
+++ b/arch/i386/pci/mmconfig-shared.c
@@ -80,7 +80,8 @@ void __init pci_mmcfg_init(int type)
}
if (pci_mmcfg_arch_init()) {
- unreachable_devices();
+ if (type == 1)
+ unreachable_devices();
pci_probe = (pci_probe & ~PCI_PROBE_MASK) | PCI_PROBE_MMCONF;
}
}
--
1.4.4.1.g278f
next prev parent reply other threads:[~2006-12-07 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 18:17 [0/5] PCI MMConfig per-chipset support - v2 Olivier Galibert
2006-12-07 18:29 ` [PATCH 1/5] PCI MMConfig: Share what's shareable Olivier Galibert
2006-12-07 18:29 ` Olivier Galibert [this message]
2006-12-07 18:30 ` [PATCH 3/5] PCI MMConfig: Only map what's necessary Olivier Galibert
2006-12-07 18:30 ` [PATCH 4/5] PCI MMConfig: Detect and support the E7520 and the 945G/GZ/P/PL Olivier Galibert
2006-12-07 18:31 ` [PATCH 5/5] PCI MMConfig: Reserve resources but only when we're sure about them Olivier Galibert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061207182940.GB73583@dspnet.fr.eu.org \
--to=galibert@pobox.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=muli@il.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®