From: Olivier Galibert <galibert@pobox.com>
To: Andi Kleen <ak@suse.de>,
linux-pci@atrey.karlin.mff.cuni.cz,
"Hack inc." <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>,
Muli Ben-Yehuda <muli@il.ibm.com>
Subject: [PATCH 3/5] PCI MMConfig: Only map what's necessary.
Date: Thu, 7 Dec 2006 19:30:11 +0100 [thread overview]
Message-ID: <20061207183011.GC73583@dspnet.fr.eu.org> (raw)
In-Reply-To: <20061207181726.GA69863@dspnet.fr.eu.org>
The x86-64 mmconfig code always map a range of MMCONFIG_APER_MAX
bytes, i.e. 256MB, whatever the number of accessible busses is. Fix
it, and add the end of the zone in the printk while we're at it.
Signed-off-by: Olivier Galibert <galibert@pobox.com>
---
arch/x86_64/pci/mmconfig.c | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/arch/x86_64/pci/mmconfig.c b/arch/x86_64/pci/mmconfig.c
index c71c181..3d13220 100644
--- a/arch/x86_64/pci/mmconfig.c
+++ b/arch/x86_64/pci/mmconfig.c
@@ -13,10 +13,6 @@
#include "pci.h"
-/* aperture is up to 256MB but BIOS may reserve less */
-#define MMCONFIG_APER_MIN (2 * 1024*1024)
-#define MMCONFIG_APER_MAX (256 * 1024*1024)
-
/* Verify the first 16 busses. We assume that systems with more busses
get MCFG right. */
#define PCI_MMCFG_MAX_CHECK_BUS 16
@@ -143,17 +139,19 @@ int __init pci_mmcfg_arch_init(void)
}
for (i = 0; i < pci_mmcfg_config_num; ++i) {
+ u32 size = (pci_mmcfg_config[0].end_bus_number - pci_mmcfg_config[0].start_bus_number + 1) << 20;
pci_mmcfg_virt[i].cfg = &pci_mmcfg_config[i];
pci_mmcfg_virt[i].virt = ioremap_nocache(pci_mmcfg_config[i].base_address,
- MMCONFIG_APER_MAX);
+ size);
if (!pci_mmcfg_virt[i].virt) {
printk(KERN_ERR "PCI: Cannot map mmconfig aperture for "
"segment %d\n",
pci_mmcfg_config[i].pci_segment_group_number);
return 0;
}
- printk(KERN_INFO "PCI: Using MMCONFIG at %x\n",
- pci_mmcfg_config[i].base_address);
+ printk(KERN_INFO "PCI: Using MMCONFIG at %x-%x\n",
+ pci_mmcfg_config[i].base_address,
+ pci_mmcfg_config[i].base_address + size - 1);
}
raw_pci_ops = &pci_mmcfg;
--
1.4.4.1.g278f
next prev parent reply other threads:[~2006-12-07 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 18:17 [0/5] PCI MMConfig per-chipset support - v2 Olivier Galibert
2006-12-07 18:29 ` [PATCH 1/5] PCI MMConfig: Share what's shareable Olivier Galibert
2006-12-07 18:29 ` [PATCH 2/5] PCI MMConfig: Only call unreachable_devices() when type 1 is available Olivier Galibert
2006-12-07 18:30 ` Olivier Galibert [this message]
2006-12-07 18:30 ` [PATCH 4/5] PCI MMConfig: Detect and support the E7520 and the 945G/GZ/P/PL Olivier Galibert
2006-12-07 18:31 ` [PATCH 5/5] PCI MMConfig: Reserve resources but only when we're sure about them Olivier Galibert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061207183011.GC73583@dspnet.fr.eu.org \
--to=galibert@pobox.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=muli@il.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®