Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

[Josef Sipek <jsipek@fsl.cs.sunysb.edu>]

On Fri, Dec 08, 2006 at 06:02:28PM +0100, Jan Engelhardt wrote:
> 
> On Dec 8 2006 11:00, Josef Sipek wrote:
> 
> +void __unionfs_mkdir(void *data)
> +{
> +	struct sioq_args *args = data;
> +	struct mkdir_args *m = &args->mkdir;
> +
> +	args->err = vfs_mkdir(m->parent, m->dentry, m->mode);
> +	complete(&args->comp);
> +}
> 
> >> The members of m (i.e. m->*) are not modified as for as __unionfs_mknod goes.
> >> vfs_mknod may only modify the members of m->parent (i.e. m->parent->*)
> > 
> >Yes they are. The return value is passed through a member of m.
> 
> Where - where do you see that m->parent, m->dentry or m->mode are modified?
> (The original submission is above.)

args->err is modified. If args is declared const, gcc complains. Sorry, the
example code I sent was a bit mis-leading (different from the actual code
above), but it triggered the same check in gcc.

Josef "Jeff" Sipek.

-- 
It used to be said [...] that AIX looks like one space alien discovered
Unix, and described it to another different space alien who then implemented
AIX. But their universal translators were broken and they'd had to gesture a
lot.
		- Paul Tomblin