mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ipc-procfs-sysctl mixups
@ 2006-12-09  8:38 Randy Dunlap
  2006-12-09  9:04 ` Eric W. Biederman
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2006-12-09  8:38 UTC (permalink / raw)
  To: lkml; +Cc: ebiederm, akpm

From: Randy Dunlap <randy.dunlap@oracle.com>

When CONFIG_PROC_FS=n and CONFIG_PROC_SYSCTL=n but CONFIG_SYSVIPC=y,
we get this build error:

kernel/built-in.o:(.data+0xc38): undefined reference to `proc_ipc_doulongvec_minmax'
kernel/built-in.o:(.data+0xc88): undefined reference to `proc_ipc_doulongvec_minmax'
kernel/built-in.o:(.data+0xcd8): undefined reference to `proc_ipc_dointvec'
kernel/built-in.o:(.data+0xd28): undefined reference to `proc_ipc_dointvec'
kernel/built-in.o:(.data+0xd78): undefined reference to `proc_ipc_dointvec'
kernel/built-in.o:(.data+0xdc8): undefined reference to `proc_ipc_dointvec'
kernel/built-in.o:(.data+0xe18): undefined reference to `proc_ipc_dointvec'
make: *** [vmlinux] Error 1

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 kernel/sysctl.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

--- linux-2.6.19-git13.orig/kernel/sysctl.c
+++ linux-2.6.19-git13/kernel/sysctl.c
@@ -2408,6 +2408,17 @@ static int proc_do_ipc_string(ctl_table 
 {
 	return -ENOSYS;
 }
+static int proc_ipc_dointvec(ctl_table *table, int write, struct file *filp,
+		void __user *buffer, size_t *lenp, loff_t *ppos)
+{
+	return -ENOSYS;
+}
+static int proc_ipc_doulongvec_minmax(ctl_table *table, int write,
+		struct file *filp, void __user *buffer,
+		size_t *lenp, loff_t *ppos)
+{
+	return -ENOSYS;
+}
 #endif
 
 int proc_dointvec(ctl_table *table, int write, struct file *filp,


---

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ipc-procfs-sysctl mixups
  2006-12-09  8:38 [PATCH] ipc-procfs-sysctl mixups Randy Dunlap
@ 2006-12-09  9:04 ` Eric W. Biederman
  0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2006-12-09  9:04 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: lkml, ebiederm, akpm

Randy Dunlap <randy.dunlap@oracle.com> writes:

> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> When CONFIG_PROC_FS=n and CONFIG_PROC_SYSCTL=n but CONFIG_SYSVIPC=y,
> we get this build error:
>
> kernel/built-in.o:(.data+0xc38): undefined reference to
> `proc_ipc_doulongvec_minmax'
> kernel/built-in.o:(.data+0xc88): undefined reference to
> `proc_ipc_doulongvec_minmax'
> kernel/built-in.o:(.data+0xcd8): undefined reference to `proc_ipc_dointvec'
> kernel/built-in.o:(.data+0xd28): undefined reference to `proc_ipc_dointvec'
> kernel/built-in.o:(.data+0xd78): undefined reference to `proc_ipc_dointvec'
> kernel/built-in.o:(.data+0xdc8): undefined reference to `proc_ipc_dointvec'
> kernel/built-in.o:(.data+0xe18): undefined reference to `proc_ipc_dointvec'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Acked-by: Eric Biederman <ebiederm@xmission.com>

Oops.  Thanks for catching this.

Eric

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-09  9:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-09  8:38 [PATCH] ipc-procfs-sysctl mixups Randy Dunlap
2006-12-09  9:04 ` Eric W. Biederman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®