* Weird code in scripts/kconfig/Makefile
@ 2006-12-13 2:09 Pete Zaitcev
2006-12-13 2:28 ` Jason Baron
2006-12-13 11:37 ` Roman Zippel
0 siblings, 2 replies; 3+ messages in thread
From: Pete Zaitcev @ 2006-12-13 2:09 UTC (permalink / raw)
To: zippel; +Cc: zaitcev, jbaron, linux-kernel
Hi, Roman & All:
In 2.6.19 (and Linus' curent tree), I found the following:
libpath=$$dir/lib; lib=qt; osdir=""; \
$(HOSTCXX) -print-multi-os-directory > /dev/null 2>&1 && \
osdir=x$$($(HOSTCXX) -print-multi-os-directory); \
test -d $$libpath/$$osdir && libpath=$$libpath/$$osdir; \
What does the little 'x' do in front of $$(foo)? It looks suspiciously
like a typo to me.
I think Jason caught it, but I didn't see a correction sent out.
-- Pete
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Weird code in scripts/kconfig/Makefile
2006-12-13 2:09 Weird code in scripts/kconfig/Makefile Pete Zaitcev
@ 2006-12-13 2:28 ` Jason Baron
2006-12-13 11:37 ` Roman Zippel
1 sibling, 0 replies; 3+ messages in thread
From: Jason Baron @ 2006-12-13 2:28 UTC (permalink / raw)
To: Pete Zaitcev; +Cc: zippel, linux-kernel
On Tue, 12 Dec 2006, Pete Zaitcev wrote:
> Hi, Roman & All:
>
> In 2.6.19 (and Linus' curent tree), I found the following:
>
> libpath=$$dir/lib; lib=qt; osdir=""; \
> $(HOSTCXX) -print-multi-os-directory > /dev/null 2>&1 && \
> osdir=x$$($(HOSTCXX) -print-multi-os-directory); \
> test -d $$libpath/$$osdir && libpath=$$libpath/$$osdir; \
>
> What does the little 'x' do in front of $$(foo)? It looks suspiciously
> like a typo to me.
>
> I think Jason caught it, but I didn't see a correction sent out.
>
yes. looks like an error to me too...i left it out of an internal patch to
this code. Since we are testing for the existence of the directory, it has
probably gone unnoticed.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Weird code in scripts/kconfig/Makefile
2006-12-13 2:09 Weird code in scripts/kconfig/Makefile Pete Zaitcev
2006-12-13 2:28 ` Jason Baron
@ 2006-12-13 11:37 ` Roman Zippel
1 sibling, 0 replies; 3+ messages in thread
From: Roman Zippel @ 2006-12-13 11:37 UTC (permalink / raw)
To: Pete Zaitcev; +Cc: jbaron, linux-kernel
Hi,
On Tue, 12 Dec 2006, Pete Zaitcev wrote:
> In 2.6.19 (and Linus' curent tree), I found the following:
>
> libpath=$$dir/lib; lib=qt; osdir=""; \
> $(HOSTCXX) -print-multi-os-directory > /dev/null 2>&1 && \
> osdir=x$$($(HOSTCXX) -print-multi-os-directory); \
> test -d $$libpath/$$osdir && libpath=$$libpath/$$osdir; \
>
> What does the little 'x' do in front of $$(foo)? It looks suspiciously
> like a typo to me.
Indeed, it looks like it. It's the fallback path nowadays, so I guess it
wasn't noticed so far.
bye, Roman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-12-13 12:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-13 2:09 Weird code in scripts/kconfig/Makefile Pete Zaitcev
2006-12-13 2:28 ` Jason Baron
2006-12-13 11:37 ` Roman Zippel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®