From: Andrew Morton <akpm@osdl.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: + down_write-preserve-local-irqs.patch added to -mm tree
Date: Wed, 20 Dec 2006 03:02:04 -0800 [thread overview]
Message-ID: <20061220030204.d070c807.akpm@osdl.org> (raw)
In-Reply-To: <1166612063.3365.1367.camel@laptopd505.fenrus.org>
On Wed, 20 Dec 2006 11:54:23 +0100
Arjan van de Ven <arjan@infradead.org> wrote:
> On Wed, 2006-12-20 at 02:38 -0800, akpm@osdl.org wrote:
> > The patch titled
> > down_write(): preserve local irqs
> > has been added to the -mm tree. Its filename is
> > down_write-preserve-local-irqs.patch
> >
> > See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> > out what to do about this
> >
> > ------------------------------------------------------
> > Subject: down_write(): preserve local irqs
>
> excuse me? Am I missing something here?
Lots.
> down_write() is a sleeping function, right? what business does it have
> to be *ever* called with irqs off?
>
> if the answer is "none whatsoever", what good is saving irq state then?
>
a) this patch is for testers to confirm that this fixes the hangs
b) there's plenty of precendent for this - powerpc won't boot if
mutex_lock() enables interrupts, for example. We just assume that
during early boot these sleeping locks aren't contended.
yes, it does suck.
prev parent reply other threads:[~2006-12-20 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200612201038.kBKAcN4L026466@shell0.pdx.osdl.net>
2006-12-20 10:54 ` Arjan van de Ven
2006-12-20 11:02 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061220030204.d070c807.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®