* Re: + down_write-preserve-local-irqs.patch added to -mm tree
[not found] <200612201038.kBKAcN4L026466@shell0.pdx.osdl.net>
@ 2006-12-20 10:54 ` Arjan van de Ven
2006-12-20 11:02 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Arjan van de Ven @ 2006-12-20 10:54 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm
On Wed, 2006-12-20 at 02:38 -0800, akpm@osdl.org wrote:
> The patch titled
> down_write(): preserve local irqs
> has been added to the -mm tree. Its filename is
> down_write-preserve-local-irqs.patch
>
> See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> out what to do about this
>
> ------------------------------------------------------
> Subject: down_write(): preserve local irqs
excuse me? Am I missing something here?
down_write() is a sleeping function, right? what business does it have
to be *ever* called with irqs off?
if the answer is "none whatsoever", what good is saving irq state then?
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: + down_write-preserve-local-irqs.patch added to -mm tree
2006-12-20 10:54 ` + down_write-preserve-local-irqs.patch added to -mm tree Arjan van de Ven
@ 2006-12-20 11:02 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-12-20 11:02 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: linux-kernel
On Wed, 20 Dec 2006 11:54:23 +0100
Arjan van de Ven <arjan@infradead.org> wrote:
> On Wed, 2006-12-20 at 02:38 -0800, akpm@osdl.org wrote:
> > The patch titled
> > down_write(): preserve local irqs
> > has been added to the -mm tree. Its filename is
> > down_write-preserve-local-irqs.patch
> >
> > See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> > out what to do about this
> >
> > ------------------------------------------------------
> > Subject: down_write(): preserve local irqs
>
> excuse me? Am I missing something here?
Lots.
> down_write() is a sleeping function, right? what business does it have
> to be *ever* called with irqs off?
>
> if the answer is "none whatsoever", what good is saving irq state then?
>
a) this patch is for testers to confirm that this fixes the hangs
b) there's plenty of precendent for this - powerpc won't boot if
mutex_lock() enables interrupts, for example. We just assume that
during early boot these sleeping locks aren't contended.
yes, it does suck.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-20 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200612201038.kBKAcN4L026466@shell0.pdx.osdl.net>
2006-12-20 10:54 ` + down_write-preserve-local-irqs.patch added to -mm tree Arjan van de Ven
2006-12-20 11:02 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®