* [patch] high-res timers: fix APIC event-broadcasting code
@ 2006-12-21 21:26 Ingo Molnar
0 siblings, 0 replies; only message in thread
From: Ingo Molnar @ 2006-12-21 21:26 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Thomas Gleixner
Subject: [patch] high-res timers: fix APIC event-broadcasting code
From: Ingo Molnar <mingo@elte.hu>
this patch fixes a bug in the APCI-C3-turns-off-lapic related
event-broadcasting code: it accidentally reactivated the global tick,
instead of the global event emulation layer.
The effect of this bug was a rare bootup hang on one of my test-laptops
- but it could also result in other types of timer related problems (but
not hangs in an already running system), such as imprecise high-res
timeouts.
Debugged via SysRq-Q.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/i386/kernel/apic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-hres-timers.q/arch/i386/kernel/apic.c
===================================================================
--- linux-hres-timers.q.orig/arch/i386/kernel/apic.c
+++ linux-hres-timers.q/arch/i386/kernel/apic.c
@@ -506,7 +506,7 @@ void switch_APIC_timer_to_ipi(void *cpum
int cpu = smp_processor_id();
if (cpu_isset(cpu, mask) && levt->event_handler)
- clockevents_set_global_broadcast(levt, 1);
+ clockevents_set_broadcast(levt, 1);
}
EXPORT_SYMBOL_GPL(switch_APIC_timer_to_ipi);
@@ -517,7 +517,7 @@ void switch_ipi_to_APIC_timer(void *cpum
int cpu = smp_processor_id();
if (cpu_isset(cpu, mask) && levt->event_handler)
- clockevents_set_global_broadcast(levt, 0);
+ clockevents_set_broadcast(levt, 0);
}
EXPORT_SYMBOL_GPL(switch_ipi_to_APIC_timer);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-12-21 21:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-21 21:26 [patch] high-res timers: fix APIC event-broadcasting code Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®