From: David Brownell <david-b@pacbell.net>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Adam Belay <abelay@novell.com>,
ambx1@neo.rr.com,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.12-rc2] PNP: export pnp_bus_type
Date: Wed, 27 Dec 2006 15:59:00 -0800 [thread overview]
Message-ID: <200612271559.02077.david-b@pacbell.net> (raw)
In-Reply-To: <1167258618.3281.4112.camel@laptopd505.fenrus.org>
On Wednesday 27 December 2006 2:30 pm, Arjan van de Ven wrote:
> On Wed, 2006-12-27 at 13:47 -0800, David Brownell wrote:
> > The PNP framework doesn't export "pnp_bus_type", which is an unfortunate
> > exception to the policy followed by pretty much every other bus. I noticed
> > this when I had to find a device in order to provide its platform_data.
>
> can you please merge the export together with the driver?
I'll send that stuff along; providing the platform data is actually
an update to ACPI glue, not the driver, so the driver won't need to
become needlessly coupled to ACPI. (Driver = rtc_cmos, I'll resend
it in a few days.)
> We already
> have way too many unused exports, and the only sane way is to merge the
> export with the user..... (and yes exports are not free, they take up
> 100 to 150 bytes of kernel size for example)
Hmm, then maybe it'd be worth updating that patch I just sent so that
the only change is to switch #includes for the extern decl ... i.e. to
"export" it only to other statically linked kernel code, rather than to
modules. I'll do that.
My own question about that EXPORT_SYMBOL was whether it instead be
an EXPORT_SYMBOL_GPL, but if either one costs bytes ... I'm happy to
avoid that cost!
- Dave
next prev parent reply other threads:[~2006-12-27 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-27 21:47 David Brownell
2006-12-27 22:30 ` Arjan van de Ven
2006-12-27 23:59 ` David Brownell [this message]
2006-12-28 10:05 ` Arjan van de Ven
2006-12-28 22:10 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612271559.02077.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=abelay@novell.com \
--cc=ambx1@neo.rr.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®