From: David Brownell <david-b@pacbell.net>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Adam Belay <abelay@novell.com>,
ambx1@neo.rr.com,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.12-rc2] PNP: export pnp_bus_type
Date: Thu, 28 Dec 2006 14:10:31 -0800 [thread overview]
Message-ID: <200612281410.31981.david-b@pacbell.net> (raw)
In-Reply-To: <1167300302.3281.4181.camel@laptopd505.fenrus.org>
On Thursday 28 December 2006 2:05 am, Arjan van de Ven wrote:
>
> > Hmm, then maybe it'd be worth updating that patch I just sent so that
> > the only change is to switch #includes for the extern decl ... i.e. to
> > "export" it only to other statically linked kernel code, rather than to
> > modules. I'll do that.
> >
> > My own question about that EXPORT_SYMBOL was whether it instead be
> > an EXPORT_SYMBOL_GPL, but if either one costs bytes ... I'm happy to
> > avoid that cost!
>
> no export if it's not *really* need is obviously superior to either of
> those so yes I like the patch you're talking about already without even
> having seen it ;)
The change is trivial ... in pnp/driver.c strike the EXPORT_SYMBOL.
So I won't bother posting it to this list; I hate wasting electrons.
I sent the updated patch to Andrew, but evidently just missed his
2.6.20-rc2-mm1 cutoff.
- Dave
prev parent reply other threads:[~2006-12-28 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-27 21:47 David Brownell
2006-12-27 22:30 ` Arjan van de Ven
2006-12-27 23:59 ` David Brownell
2006-12-28 10:05 ` Arjan van de Ven
2006-12-28 22:10 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612281410.31981.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=abelay@novell.com \
--cc=ambx1@neo.rr.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®