mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2.6.20-rc2] Fix set_pte_at arguments in page_mkclean_one
@ 2006-12-29  4:13 Balbir Singh
  2006-12-29  4:57 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Balbir Singh @ 2006-12-29  4:13 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linux Kernel, Balbir Singh

page_mkclean_one() passes vma instead of the expected mm as argument1 to
set_pte_at. Below is a simple fix (tested by compiling the kernel on
powerpc). Please ignore the patch, if a fix has already been applied.

Signed-off-by: Balbir Singh <balbir@in.ibm.com>
---

 mm/rmap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN mm/rmap.c~fix-set-pte-in-page_mkclean_one mm/rmap.c
--- linux-2.6.20-rc2/mm/rmap.c~fix-set-pte-in-page_mkclean_one	2006-12-29 09:18:26.000000000 +0530
+++ linux-2.6.20-rc2-balbir/mm/rmap.c	2006-12-29 09:25:28.000000000 +0530
@@ -461,7 +461,7 @@ static int page_mkclean_one(struct page 
 		entry = ptep_clear_flush(vma, address, pte);
 		entry = pte_wrprotect(entry);
 		entry = pte_mkclean(entry);
-		set_pte_at(vma, address, pte, entry);
+		set_pte_at(mm, address, pte, entry);
 		lazy_mmu_prot_update(entry);
 		ret = 1;
 	}
_

-- 

	Balbir Singh,
	Linux Technology Center,
	IBM Software Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2.6.20-rc2] Fix set_pte_at arguments in page_mkclean_one
  2006-12-29  4:13 [PATCH 2.6.20-rc2] Fix set_pte_at arguments in page_mkclean_one Balbir Singh
@ 2006-12-29  4:57 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-12-29  4:57 UTC (permalink / raw)
  To: balbir; +Cc: akpm, linux-kernel

From: Balbir Singh <balbir@in.ibm.com>
Date: Fri, 29 Dec 2006 09:43:10 +0530

> page_mkclean_one() passes vma instead of the expected mm as argument1 to
> set_pte_at. Below is a simple fix (tested by compiling the kernel on
> powerpc). Please ignore the patch, if a fix has already been applied.
> 
> Signed-off-by: Balbir Singh <balbir@in.ibm.com>

Good catch.

Signed-off-by: David S. Miller <davem@davemloft.net>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-29  4:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-29  4:13 [PATCH 2.6.20-rc2] Fix set_pte_at arguments in page_mkclean_one Balbir Singh
2006-12-29  4:57 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®