mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] net: af_netlink module_put cleanup
@ 2007-01-02 12:47 Mariusz Kozlowski
  2007-01-02 23:25 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Mariusz Kozlowski @ 2007-01-02 12:47 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: netdev, linux-kernel

Hello,

	This patch removes redundant argument check for module_put().

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

 net/netlink/af_netlink.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff -upr linux-2.6.20-rc2-mm1-a/net/netlink/af_netlink.c linux-2.6.20-rc2-mm1-b/net/netlink/af_netlink.c
--- linux-2.6.20-rc2-mm1-a/net/netlink/af_netlink.c	2006-12-24 05:00:32.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/net/netlink/af_netlink.c	2007-01-02 02:23:02.000000000 +0100
@@ -472,8 +472,7 @@ static int netlink_release(struct socket
 				NETLINK_URELEASE, &n);
 	}	
 
-	if (nlk->module)
-		module_put(nlk->module);
+	module_put(nlk->module);
 
 	netlink_table_grab();
 	if (nlk->flags & NETLINK_KERNEL_SOCKET) {


-- 
Regards,

	Mariusz Kozlowski

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: af_netlink module_put cleanup
  2007-01-02 12:47 [PATCH] net: af_netlink module_put cleanup Mariusz Kozlowski
@ 2007-01-02 23:25 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-01-02 23:25 UTC (permalink / raw)
  To: m.kozlowski; +Cc: jgarzik, netdev, linux-kernel

From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Date: Tue, 2 Jan 2007 13:47:37 +0100

> Hello,
> 
> 	This patch removes redundant argument check for module_put().
> 
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-01-02 23:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-02 12:47 [PATCH] net: af_netlink module_put cleanup Mariusz Kozlowski
2007-01-02 23:25 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®