[PATCH] Remove a couple final references to obsolete verify_area().

[PATCH] Remove a couple final references to obsolete verify_area().

[Robert P. J. Day]

  Remove a couple final references to the obsolete verify_area() call,
which was long ago replaced by access_ok().

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

  it *appears* that these last two references can be removed, unless
there's something really strange i'm not seeing here.


 include/asm-avr32/checksum.h |    2 +-
 include/asm-avr32/uaccess.h  |    6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)


diff --git a/include/asm-avr32/checksum.h b/include/asm-avr32/checksum.h
index af9d53f..4ddbfd2 100644
--- a/include/asm-avr32/checksum.h
+++ b/include/asm-avr32/checksum.h
@@ -38,7 +38,7 @@ __wsum csum_partial_copy_generic(const void *src, void *dst, int len,
  *	passed in an incorrect kernel address to one of these functions.
  *
  *	If you use these functions directly please don't forget the
- *	verify_area().
+ *	access_ok().
  */
 static inline
 __wsum csum_partial_copy_nocheck(const void *src, void *dst,
diff --git a/include/asm-avr32/uaccess.h b/include/asm-avr32/uaccess.h
index 821deb5..74a679e 100644
--- a/include/asm-avr32/uaccess.h
+++ b/include/asm-avr32/uaccess.h
@@ -68,12 +68,6 @@ static inline void set_fs(mm_segment_t s)

 #define access_ok(type, addr, size) (likely(__range_ok(addr, size) == 0))

-static inline int
-verify_area(int type, const void __user *addr, unsigned long size)
-{
-	return access_ok(type, addr, size) ? 0 : -EFAULT;
-}
-
 /* Generic arbitrary sized copy. Return the number of bytes NOT copied */
 extern __kernel_size_t __copy_user(void *to, const void *from,
 				   __kernel_size_t n);

Re: [PATCH] Remove a couple final references to obsolete verify_area().

[Haavard Skinnemoen]

On Sun, 7 Jan 2007 18:43:41 -0500 (EST)
"Robert P. J. Day" <rpjday@mindspring.com> wrote:

> 
>   Remove a couple final references to the obsolete verify_area() call,
> which was long ago replaced by access_ok().
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

Acked-by: Haavard Skinnemoen <hskinnemoen@atmel.com>

>   it *appears* that these last two references can be removed, unless
> there's something really strange i'm not seeing here.

The kernel builds and boots fine after applying this patch, so I think
verify_area is indeed unused. If it breaks something outside of
mainline, I guess it's about time we get it fixed.

Thanks,

Haavard

Re: [PATCH] Remove a couple final references to obsolete verify_area().

[Jesper Juhl]

On 08/01/07, Robert P. J. Day <rpjday@mindspring.com> wrote:
>
>   Remove a couple final references to the obsolete verify_area() call,
> which was long ago replaced by access_ok().
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
>   it *appears* that these last two references can be removed, unless
> there's something really strange i'm not seeing here.
>

The AVR32 code went in roughly a month after I did the last
verify_area() cleanup patch, so I missed these bits.
The patch looks sane to me, so feel free to add

Acked-by: Jesper Juhl <jesper.juhl@gmail.com>

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html