From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
linux-pcmcia@lists.infradead.org
Subject: Re: [PATCH] Remove useless FIND_FIRST_BIT() macro from cardbus.c.
Date: Mon, 8 Jan 2007 18:45:14 -0800 [thread overview]
Message-ID: <20070108184514.6034ccb5.randy.dunlap@oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0701082015270.3951@localhost.localdomain>
On Mon, 8 Jan 2007 20:20:28 -0500 (EST) Robert P. J. Day wrote:
>
> Delete the definition of the unused FIND_FIRST_BIT() macro.
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
> this macro seems safely deletable, given that there is no other
> reference to that macro anywhere in the entire source tree and,
> besides, one should use find_first_bit() anyway.
>
> it's not clear who the official maintainer is for this subsystem
> these days.
I believe that it should go to (from MAINTAINERS):
PCMCIA SUBSYSTEM
P: Linux PCMCIA Team
L: linux-pcmcia@lists.infradead.org
L: http://lists.infradead.org/mailman/listinfo/linux-pcmcia
T: git kernel.org:/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git
S: Maintained
> diff --git a/drivers/pcmcia/cardbus.c b/drivers/pcmcia/cardbus.c
> index 2d7effe..a1bd763 100644
> --- a/drivers/pcmcia/cardbus.c
> +++ b/drivers/pcmcia/cardbus.c
> @@ -40,8 +40,6 @@
>
> /*====================================================================*/
>
> -#define FIND_FIRST_BIT(n) ((n) - ((n) & ((n)-1)))
> -
> /* Offsets in the Expansion ROM Image Header */
> #define ROM_SIGNATURE 0x0000 /* 2 bytes */
> #define ROM_DATA_PTR 0x0018 /* 2 bytes */
> -
---
~Randy
prev parent reply other threads:[~2007-01-09 2:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-09 1:20 Robert P. J. Day
2007-01-09 2:45 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070108184514.6034ccb5.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®