* [PATCH] Remove useless FIND_FIRST_BIT() macro from cardbus.c.
@ 2007-01-09 1:20 Robert P. J. Day
2007-01-09 2:45 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2007-01-09 1:20 UTC (permalink / raw)
To: Linux kernel mailing list; +Cc: Andrew Morton
Delete the definition of the unused FIND_FIRST_BIT() macro.
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
---
this macro seems safely deletable, given that there is no other
reference to that macro anywhere in the entire source tree and,
besides, one should use find_first_bit() anyway.
it's not clear who the official maintainer is for this subsystem
these days.
diff --git a/drivers/pcmcia/cardbus.c b/drivers/pcmcia/cardbus.c
index 2d7effe..a1bd763 100644
--- a/drivers/pcmcia/cardbus.c
+++ b/drivers/pcmcia/cardbus.c
@@ -40,8 +40,6 @@
/*====================================================================*/
-#define FIND_FIRST_BIT(n) ((n) - ((n) & ((n)-1)))
-
/* Offsets in the Expansion ROM Image Header */
#define ROM_SIGNATURE 0x0000 /* 2 bytes */
#define ROM_DATA_PTR 0x0018 /* 2 bytes */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove useless FIND_FIRST_BIT() macro from cardbus.c.
2007-01-09 1:20 [PATCH] Remove useless FIND_FIRST_BIT() macro from cardbus.c Robert P. J. Day
@ 2007-01-09 2:45 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2007-01-09 2:45 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux kernel mailing list, Andrew Morton, linux-pcmcia
On Mon, 8 Jan 2007 20:20:28 -0500 (EST) Robert P. J. Day wrote:
>
> Delete the definition of the unused FIND_FIRST_BIT() macro.
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
> this macro seems safely deletable, given that there is no other
> reference to that macro anywhere in the entire source tree and,
> besides, one should use find_first_bit() anyway.
>
> it's not clear who the official maintainer is for this subsystem
> these days.
I believe that it should go to (from MAINTAINERS):
PCMCIA SUBSYSTEM
P: Linux PCMCIA Team
L: linux-pcmcia@lists.infradead.org
L: http://lists.infradead.org/mailman/listinfo/linux-pcmcia
T: git kernel.org:/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git
S: Maintained
> diff --git a/drivers/pcmcia/cardbus.c b/drivers/pcmcia/cardbus.c
> index 2d7effe..a1bd763 100644
> --- a/drivers/pcmcia/cardbus.c
> +++ b/drivers/pcmcia/cardbus.c
> @@ -40,8 +40,6 @@
>
> /*====================================================================*/
>
> -#define FIND_FIRST_BIT(n) ((n) - ((n) & ((n)-1)))
> -
> /* Offsets in the Expansion ROM Image Header */
> #define ROM_SIGNATURE 0x0000 /* 2 bytes */
> #define ROM_DATA_PTR 0x0018 /* 2 bytes */
> -
---
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-09 2:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-09 1:20 [PATCH] Remove useless FIND_FIRST_BIT() macro from cardbus.c Robert P. J. Day
2007-01-09 2:45 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®