From: Herbert Xu <herbert@gondor.apana.org.au>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, deweerdt@free.fr,
netdev@vger.kernel.org, frederik.deweerdt@gmail.com,
shemminger@osdl.org
Subject: Re: + oops-in-drivers-net-shaperc.patch added to -mm tree
Date: Sat, 27 Jan 2007 12:01:46 +1100 [thread overview]
Message-ID: <20070127010146.GA18851@gondor.apana.org.au> (raw)
In-Reply-To: <E1HAbgn-00039h-00@gondolin.me.apana.org.au>
On Sat, Jan 27, 2007 at 11:45:05AM +1100, Herbert Xu wrote:
> David Miller <davem@davemloft.net> wrote:
> >
> > Shaper is actually OK. None of these hardware header callbacks
> > should be invoked if the device is down. Yet, this is what is
> > accidently being allowed in the AF_PACKET socket layer.
>
> Hmm, what if the device goes down after the check?
In fact, the shaper device doesn't even seem to take a ref count of
the device it has attached to. So that device can go away at any time.
What's more, there are drivers that can change hard_header at run-time
(s390).
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2007-01-27 1:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200701250354.l0P3spES005128@shell0.pdx.osdl.net>
2007-01-26 3:31 ` David Miller
2007-01-27 0:45 ` Herbert Xu
2007-01-27 1:01 ` Herbert Xu [this message]
2007-01-27 3:12 ` David Miller
2007-01-27 3:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070127010146.GA18851@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=deweerdt@free.fr \
--cc=frederik.deweerdt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®