From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: "Parag Warudkar" <parag.warudkar@gmail.com>,
thunder7@xs4all.nl, linux-kernel@vger.kernel.org
Subject: Re: 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages
Date: Mon, 29 Jan 2007 00:59:40 -0800 [thread overview]
Message-ID: <20070129005940.04c3d6d1.akpm@osdl.org> (raw)
In-Reply-To: <200701290351.54270.ak@suse.de>
On Mon, 29 Jan 2007 03:51:54 +0100
Andi Kleen <ak@suse.de> wrote:
>
> > I think the easy and correct fix for this situation is defining
> > CONFIG_ARCH_HAS_SETUP_ADDITIONAL_PAGES on x86_64 only if
> > IA32_EMULATION is defined. (Because x86_64 proper doesn't seem to
> > require arch_setup_additional_pages() only IA32 emulation requires
> > it.)
> >
> > The patch below should fix it. (Please use attachment - less chance of
> > whitespace issues. Sorry no control over mail client atm)
>
> A more elegant solution would be to do away with the CONFIG
> and switch to a weak function in the caller.
>
Now why didn't I think of that?
next prev parent reply other threads:[~2007-01-29 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-28 16:34 Parag Warudkar
2007-01-28 22:44 ` Parag Warudkar
2007-01-29 2:51 ` Andi Kleen
2007-01-29 8:59 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-01-28 7:49 2.6.20-rc6-mm1 Andrew Morton
2007-01-28 14:59 ` 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages thunder7
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070129005940.04c3d6d1.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=parag.warudkar@gmail.com \
--cc=thunder7@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome