From: "Parag Warudkar" <parag.warudkar@gmail.com>
To: thunder7@xs4all.nl
Cc: "akpm@osdl.org" <akpm@osdl.org>,
ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages
Date: Sun, 28 Jan 2007 17:44:26 -0500 [thread overview]
Message-ID: <82e4877d0701281444h333c581fr66d60cca9d03749d@mail.gmail.com> (raw)
In-Reply-To: <82e4877d0701280834n75d3d0d3ja7a35d5ea0e7fa4f@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]
On 1/28/07, Parag Warudkar <parag.warudkar@gmail.com> wrote:
> >CONFIG_BINFMT_ELF=y
> ># CONFIG_BINFMT_MISC is not set
> ># CONFIG_IA32_EMULATION is not set
>
> Hm Ok. That's explainable. You don't have CONFIG_IA32_EMULATION set
> and arch_setup_additional pages is only defined/exported in
> syscall32.c which won't be built in your case. (It should go away if
> you set CONFIG_IA32_EMULATION).
>
I think the easy and correct fix for this situation is defining
CONFIG_ARCH_HAS_SETUP_ADDITIONAL_PAGES on x86_64 only if
IA32_EMULATION is defined. (Because x86_64 proper doesn't seem to
require arch_setup_additional_pages() only IA32 emulation requires
it.)
The patch below should fix it. (Please use attachment - less chance of
whitespace issues. Sorry no control over mail client atm)
Signed-off-by: Parag Warudkar <parag.warudkar@gmail.com>
--- linux-2.6.20-rc6-mm1/arch/x86_64/Kconfig.orig 2007-01-28
17:32:09.000000000 -0500
+++ linux-2.6.20-rc6-mm1/arch/x86_64/Kconfig 2007-01-28 17:32:48.000000000 -0500
@@ -405,7 +405,7 @@
config ARCH_HAS_SETUP_ADDITIONAL_PAGES
bool
default y
- depends on X86_64
+ depends on X86_64 && IA32_EMULATION
config OUT_OF_LINE_PFN_TO_PAGE
def_bool y
[-- Attachment #2: x86_64-Kconfig-fix-setup_additional_pages.patch --]
[-- Type: text/x-patch, Size: 351 bytes --]
--- linux-2.6.20-rc6-mm1/arch/x86_64/Kconfig.orig 2007-01-28 17:32:09.000000000 -0500
+++ linux-2.6.20-rc6-mm1/arch/x86_64/Kconfig 2007-01-28 17:32:48.000000000 -0500
@@ -405,7 +405,7 @@
config ARCH_HAS_SETUP_ADDITIONAL_PAGES
bool
default y
- depends on X86_64
+ depends on X86_64 && IA32_EMULATION
config OUT_OF_LINE_PFN_TO_PAGE
def_bool y
next prev parent reply other threads:[~2007-01-28 22:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-28 16:34 Parag Warudkar
2007-01-28 22:44 ` Parag Warudkar [this message]
2007-01-29 2:51 ` Andi Kleen
2007-01-29 8:59 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2007-01-28 7:49 2.6.20-rc6-mm1 Andrew Morton
2007-01-28 14:59 ` 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages thunder7
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82e4877d0701281444h333c581fr66d60cca9d03749d@mail.gmail.com \
--to=parag.warudkar@gmail.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thunder7@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®