From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: A CodingStyle suggestion
Date: Sat, 3 Feb 2007 13:59:51 -0800 [thread overview]
Message-ID: <20070203135951.564e5fe2.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20070203215848.GA10440@Ahmed>
On Sat, 3 Feb 2007 23:58:48 +0200 Ahmed S. Darwish wrote:
> Hi all,
>
> In CodingStyle Chapter 16 "Function return value and names", why not
> adding a comment about the favorable community way of checking the return
> value. ie:
>
> ret = do_method();
> if (ret) {
> /* deal with error */
> }
>
> and not other ways like:
>
> if (do_method()) or if ((ret = do_method()) > value) ...
>
> A patch is ready if the replies are positive.
I like it. Please cc: Andrew Morton <akpm@osdl.org> on it.
Hopefully he will merge it.
---
~Randy
next prev parent reply other threads:[~2007-02-03 22:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-03 21:58 Ahmed S. Darwish
2007-02-03 21:59 ` Randy Dunlap [this message]
2007-02-04 12:48 ` Theodore Tso
2007-02-04 12:55 ` Manu Abraham
2007-02-04 12:57 ` Robert P. J. Day
2007-02-03 22:56 ` Richard Knutsson
2007-02-04 0:05 ` Ahmed S. Darwish
2007-02-04 0:21 ` Roland Dreier
2007-02-04 0:40 ` Randy Dunlap
2007-02-04 6:35 ` Willy Tarreau
2007-02-04 0:22 ` Tim Schmielau
2007-02-04 0:39 ` Richard Knutsson
2007-02-04 12:10 ` Ahmed S. Darwish
2007-02-04 12:36 ` Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070203135951.564e5fe2.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=darwish.07@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®