* [PATCH] HIL: fix improper call of release_region v2
@ 2007-02-15 19:25 Cyrill V. Gorcunov
2007-02-15 19:31 ` Helge Deller
0 siblings, 1 reply; 3+ messages in thread
From: Cyrill V. Gorcunov @ 2007-02-15 19:25 UTC (permalink / raw)
To: Helge Deller; +Cc: Andrew Morton, linux-kernel-list
Thist patch prevents from improper call of release_region
if the code has been compiled without CONFIG_HP300 support.
Signed-off-by: Cyrill V. Gorcunov <gorcunov@gmail.com>
---
An improved version (v2). Helge, please check it and Ack then.
drivers/input/keyboard/hilkbd.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/input/keyboard/hilkbd.c b/drivers/input/keyboard/hilkbd.c
index 255a6ec..4de4dc2 100644
--- a/drivers/input/keyboard/hilkbd.c
+++ b/drivers/input/keyboard/hilkbd.c
@@ -294,8 +294,10 @@ err3:
disable_irq(HIL_IRQ);
free_irq(HIL_IRQ, hil_dev.dev_id);
err2:
+#if defined(CONFIG_HP300)
release_region(HILBASE + HIL_DATA, 2);
err1:
+#endif
input_free_device(hil_dev.dev);
hil_dev.dev = NULL;
return err;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HIL: fix improper call of release_region v2
2007-02-15 19:25 [PATCH] HIL: fix improper call of release_region v2 Cyrill V. Gorcunov
@ 2007-02-15 19:31 ` Helge Deller
2007-02-15 20:22 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Helge Deller @ 2007-02-15 19:31 UTC (permalink / raw)
To: Cyrill V. Gorcunov; +Cc: Andrew Morton, linux-kernel-list
On Thursday 15 February 2007, Cyrill V. Gorcunov wrote:
> Thist patch prevents from improper call of release_region
> if the code has been compiled without CONFIG_HP300 support.
>
> Signed-off-by: Cyrill V. Gorcunov <gorcunov@gmail.com>
Acked-by: Helge Deller <deller@gmx.de>
> ---
>
> An improved version (v2). Helge, please check it and Ack then.
>
> drivers/input/keyboard/hilkbd.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/keyboard/hilkbd.c b/drivers/input/keyboard/hilkbd.c
> index 255a6ec..4de4dc2 100644
> --- a/drivers/input/keyboard/hilkbd.c
> +++ b/drivers/input/keyboard/hilkbd.c
> @@ -294,8 +294,10 @@ err3:
> disable_irq(HIL_IRQ);
> free_irq(HIL_IRQ, hil_dev.dev_id);
> err2:
> +#if defined(CONFIG_HP300)
> release_region(HILBASE + HIL_DATA, 2);
> err1:
> +#endif
> input_free_device(hil_dev.dev);
> hil_dev.dev = NULL;
> return err;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HIL: fix improper call of release_region v2
2007-02-15 19:31 ` Helge Deller
@ 2007-02-15 20:22 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2007-02-15 20:22 UTC (permalink / raw)
To: Helge Deller; +Cc: Cyrill V. Gorcunov, Andrew Morton, linux-kernel-list
On 2/15/07, Helge Deller <deller@gmx.de> wrote:
> On Thursday 15 February 2007, Cyrill V. Gorcunov wrote:
> > Thist patch prevents from improper call of release_region
> > if the code has been compiled without CONFIG_HP300 support.
> >
> > Signed-off-by: Cyrill V. Gorcunov <gorcunov@gmail.com>
>
> Acked-by: Helge Deller <deller@gmx.de>
>
Will apply, thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-02-15 20:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-15 19:25 [PATCH] HIL: fix improper call of release_region v2 Cyrill V. Gorcunov
2007-02-15 19:31 ` Helge Deller
2007-02-15 20:22 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®