From: olof@lixom.net (Olof Johansson)
To: trond.myklebust@fys.uio.no
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] nfs: init req_lock in nfs_alloc_inode
Date: Fri, 16 Feb 2007 11:05:32 -0600 [thread overview]
Message-ID: <20070216170532.GA4895@lixom.net> (raw)
Seems like req_lock is never initialized. CONFIG_DEBUG_SPINLOCK reported:
BUG: spinlock bad magic on CPU#0, mount/1073
lock: c00000007fdca108, .magic: 00000000, .owner: /24576, .owner_cpu: 0
Call Trace:
[C00000007E913750] [C0000000000107B4] .show_stack+0x54/0x1f0 (unreliable)
[C00000007E913800] [C0000000001D2234] .spin_bug+0xa4/0x120
[C00000007E913890] [C0000000001D247C] ._raw_spin_lock+0xdc/0x1d0
[C00000007E913930] [C0000000004DF990] ._spin_lock+0x10/0x30
[C00000007E9139B0] [C00000000017623C] .nfs_sync_mapping_wait+0xac/0x310
[C00000007E913AA0] [C000000000176F18] .nfs_sync_mapping_range+0x98/0x110
[C00000007E913B80] [C00000000016CAA0] .nfs_getattr+0x40/0xf0
[C00000007E913C20] [C0000000000BE668] .vfs_getattr+0x38/0x70
[C00000007E913CA0] [C0000000000BF05C] .vfs_fstat+0x3c/0x70
[C00000007E913D30] [C0000000000BF0B8] .sys_fstat64+0x28/0x60
[C00000007E913E30] [C000000000008608] syscall_exit+0x0/0x40
Signed-off-by: Olof Johansson <olof@lixom.net>
---
Trond, is your MAINTAINERS entry up to date? Seems like you mostly post
from @netapp.com these days.
Index: linux-2.6/fs/nfs/inode.c
===================================================================
--- linux-2.6.orig/fs/nfs/inode.c
+++ linux-2.6/fs/nfs/inode.c
@@ -1123,6 +1123,7 @@ struct inode *nfs_alloc_inode(struct sup
nfsi->flags = 0UL;
nfsi->cache_validity = 0UL;
nfsi->cache_change_attribute = jiffies;
+ nfsi->req_lock = SPIN_LOCK_UNLOCKED;
#ifdef CONFIG_NFS_V3_ACL
nfsi->acl_access = ERR_PTR(-EAGAIN);
nfsi->acl_default = ERR_PTR(-EAGAIN);
next reply other threads:[~2007-02-16 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 17:05 Olof Johansson [this message]
2007-02-17 0:15 ` Andrew Morton
2007-02-17 1:24 ` Andrew Morton
2007-02-18 20:32 ` Olof Johansson
2007-02-20 15:10 ` Trond Myklebust
2007-02-20 17:23 ` Olof Johansson
2007-02-21 0:37 ` Trond Myklebust
2007-02-22 20:13 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070216170532.GA4895@lixom.net \
--to=olof@lixom.net \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®