From: Ralf Baechle <ralf@linux-mips.org>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 2.6.21-rc1] serial: serial_txx9 driver update
Date: Wed, 21 Feb 2007 17:00:32 +0000 [thread overview]
Message-ID: <20070221170032.GA3036@linux-mips.org> (raw)
In-Reply-To: <20070221164826.61d0b5ea@lxorguk.ukuu.org.uk>
On Wed, Feb 21, 2007 at 04:48:26PM +0000, Alan wrote:
> Given this costs 1uS in a path that is not performance critical is it
> worth putting the #ifdef/#endif in instead of having one set of code that
> works for all ?
>
> > + while (sio_in(up, TXX9_SIFCR) & TXX9_SIFCR_SWRST)
> > + ;
>
> Suppose it doesn't clear ? Should also use cpu_relax() in busy loops
> so any processor variant with power management can do the right thing.
Right now we don't have much that we could do in cpu_relax() on MIPS.
The average CPU core makes extensive use of clock gating to the point
where there are few powersaving knobs left in the core. Of course I'm
also ignoring things outside the CPU core and clockscaling for which
cpu_relax() would simply be the wrong place.
Of course this driver in rare instances might run on an x86 CPU ...
Ralf
next prev parent reply other threads:[~2007-02-21 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 15:31 Atsushi Nemoto
2007-02-21 16:48 ` Alan
2007-02-21 17:00 ` Ralf Baechle [this message]
2007-02-21 17:02 ` Atsushi Nemoto
2007-02-21 18:11 ` Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221170032.GA3036@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®