From: Alan <alan@lxorguk.ukuu.org.uk>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
ralf@linux-mips.org
Subject: Re: [PATCH 2.6.21-rc1] serial: serial_txx9 driver update
Date: Wed, 21 Feb 2007 18:11:28 +0000 [thread overview]
Message-ID: <20070221181128.3a19d66c@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20070222.020242.51866797.anemo@mba.ocn.ne.jp>
> Then I'll put udelay() and a timeout counter for it. If udelay() was
> in the busy loop, cpu_relax() is still recommended?
The udelay should deal with it for you.
> Here is a patch on top of the previous one. If this was OK I'll fold
> it into one patch.
Looks good to me
> + while ((sio_in(up, TXX9_SIFCR) & TXX9_SIFCR_SWRST) && --tmout)
> + udelay(1);
> /* TX Int by FIFO Empty, RX Int by Receiving 1 char. */
> sio_set(up, TXX9_SIFCR,
> TXX9_SIFCR_TDIL_MAX | TXX9_SIFCR_RDIL_1);
--
--
Sick of rip off UK rail fares ? Learn how to get far cheaper fares
http://zeniv.linux.org.uk/~alan/GTR/
prev parent reply other threads:[~2007-02-21 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 15:31 Atsushi Nemoto
2007-02-21 16:48 ` Alan
2007-02-21 17:00 ` Ralf Baechle
2007-02-21 17:02 ` Atsushi Nemoto
2007-02-21 18:11 ` Alan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221181128.3a19d66c@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®