mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: divy@chelsio.com
Cc: jeff@garzik.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, swise@opengridcomputing.com,
	yoshfuji@linux-ipv6.org
Subject: Re: [PATCH 2/7] cxgb3 - private ioctl cleanup
Date: Thu, 22 Feb 2007 21:06:18 +0900 (JST)	[thread overview]
Message-ID: <20070222.210618.134161490.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <20070222115925.10001.61276.stgit@localhost.localdomain>

In article <20070222115925.10001.61276.stgit@localhost.localdomain> (at Thu, 22 Feb 2007 03:59:25 -0800), divy@chelsio.com says:

> From: Divy Le Ray <divy@chelsio.com>
> 
> Clean up some private ioctls.
> 
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
> ---
> 
>  drivers/net/cxgb3/cxgb3_ioctl.h |   21 ++++-------------
>  drivers/net/cxgb3/cxgb3_main.c  |   48 +++------------------------------------
>  2 files changed, 9 insertions(+), 60 deletions(-)
> 
> diff --git a/drivers/net/cxgb3/cxgb3_ioctl.h b/drivers/net/cxgb3/cxgb3_ioctl.h
> index a942818..42d4bf6 100644
> --- a/drivers/net/cxgb3/cxgb3_ioctl.h
> +++ b/drivers/net/cxgb3/cxgb3_ioctl.h
> @@ -36,28 +36,17 @@
>   * Ioctl commands specific to this driver.
>   */
>  enum {
> -	CHELSIO_SETREG = 1024,
> -	CHELSIO_GETREG,
> -	CHELSIO_SETTPI,
> -	CHELSIO_GETTPI,
> -	CHELSIO_GETMTUTAB,
> +	CHELSIO_GETMTUTAB = 1024,
>  	CHELSIO_SETMTUTAB,
> -	CHELSIO_GETMTU,
> -	CHELSIO_SET_PM,
> -	CHELSIO_GET_PM,
> -	CHELSIO_GET_TCAM,
> -	CHELSIO_SET_TCAM,
> -	CHELSIO_GET_TCB,
>  	CHELSIO_GET_MEM,
>  	CHELSIO_LOAD_FW,
> -	CHELSIO_GET_PROTO,
> -	CHELSIO_SET_PROTO,
>  	CHELSIO_SET_TRACE_FILTER,
> -	CHELSIO_SET_QSET_PARAMS,
>  	CHELSIO_GET_QSET_PARAMS,
> -	CHELSIO_SET_QSET_NUM,
> +	CHELSIO_SET_QSET_PARAMS,
>  	CHELSIO_GET_QSET_NUM,
> -	CHELSIO_SET_PKTSCHED,
> +	CHELSIO_SET_QSET_NUM,
> +	CHELSIO_GET_PM,
> +	CHELSIO_SET_PM,
>  };
>  

I disagree. This is very bad.

1. Please do do change the values.
2. Explain why you are going to kill these ioctls.

Regards,

--yoshfuji

  reply	other threads:[~2007-02-22 12:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-22 11:59 divy
2007-02-22 12:06 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2007-02-22 12:34   ` Divy Le Ray
2007-02-22 12:39     ` YOSHIFUJI Hideaki / 吉藤英明
2007-02-22 12:50       ` Divy Le Ray
2007-02-22 14:11         ` YOSHIFUJI Hideaki / 吉藤英明
2007-02-25  0:43 divy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070222.210618.134161490.yoshfuji@linux-ipv6.org \
    --to=yoshfuji@linux-ipv6.org \
    --cc=divy@chelsio.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®