From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: divy@chelsio.com
Cc: jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, swise@opengridcomputing.com,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH 2/7] cxgb3 - private ioctl cleanup
Date: Thu, 22 Feb 2007 23:11:24 +0900 (JST) [thread overview]
Message-ID: <20070222.231124.58336645.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <45DD917D.5010807@chelsio.com>
In article <45DD917D.5010807@chelsio.com> (at Thu, 22 Feb 2007 04:50:05 -0800), Divy Le Ray <divy@chelsio.com> says:
> > Even if you remove them, PLEASE DO NOT CHANGE THE VALUES,
> > unless you have very, very good reason.
:
> The cxgb3 driver has not yet appeared in a stable version of the linux
> kernel.
> The odds of breaking an application using these private ioctls are
> pretty slim.
> Since some cleanup was required, I chose not to let holes between the
> values.
Even so, if I were you, I would not have changed them and
I would even try keeping compatibility with old (out-kernel)
drivers.
--yoshfuji
next prev parent reply other threads:[~2007-02-22 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 11:59 divy
2007-02-22 12:06 ` YOSHIFUJI Hideaki / 吉藤英明
2007-02-22 12:34 ` Divy Le Ray
2007-02-22 12:39 ` YOSHIFUJI Hideaki / 吉藤英明
2007-02-22 12:50 ` Divy Le Ray
2007-02-22 14:11 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2007-02-25 0:43 divy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070222.231124.58336645.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®