mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: mingo@elte.hu
Cc: ebiederm@xmission.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: [patch] fix the irq migration
Date: Thu, 22 Feb 2007 17:21:36 -0800	[thread overview]
Message-ID: <20070222172135.A27563@unix-os.sc.intel.com> (raw)

While debugging some other irq migration issue, observed this issue with
-git kernels. Ingo, please ACK it.
---

With the commit 76d2160147f43f982dfe881404cfde9fd0a9da21, irq_chip
default_disable() became an empty function. And with this change, irq
migration in the case of Edge triggered IO-APIC and MSI interrupts happens
with out masking the irq.

Appended patch fixes by using the mask/unmask handlers of irq_chip directly
while doing the irq migration.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---

diff --git a/kernel/irq/migration.c b/kernel/irq/migration.c
index 4baa3bb..14ff345 100644
--- a/kernel/irq/migration.c
+++ b/kernel/irq/migration.c
@@ -66,11 +66,11 @@ void move_native_irq(int irq)
 		return;
 
 	if (likely(!(desc->status & IRQ_DISABLED)))
-		desc->chip->disable(irq);
+		desc->chip->mask(irq);
 
 	move_masked_irq(irq);
 
 	if (likely(!(desc->status & IRQ_DISABLED)))
-		desc->chip->enable(irq);
+		desc->chip->unmask(irq);
 }
 

             reply	other threads:[~2007-02-23  1:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-23  1:21 Siddha, Suresh B [this message]
2007-02-23  6:52 ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070222172135.A27563@unix-os.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome