From: ebiederm@xmission.com (Eric W. Biederman)
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: mingo@elte.hu, ebiederm@xmission.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch] fix the irq migration
Date: Thu, 22 Feb 2007 23:52:50 -0700 [thread overview]
Message-ID: <m1ps81wekd.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070222172135.A27563@unix-os.sc.intel.com> (Suresh B. Siddha's message of "Thu, 22 Feb 2007 17:21:36 -0800")
"Siddha, Suresh B" <suresh.b.siddha@intel.com> writes:
> While debugging some other irq migration issue, observed this issue with
> -git kernels. Ingo, please ACK it.
> ---
>
> With the commit 76d2160147f43f982dfe881404cfde9fd0a9da21, irq_chip
> default_disable() became an empty function. And with this change, irq
> migration in the case of Edge triggered IO-APIC and MSI interrupts happens
> with out masking the irq.
>
> Appended patch fixes by using the mask/unmask handlers of irq_chip directly
> while doing the irq migration.
Close.
If the irq is disabled we need to bail out instead of skipping the
masking.
The masking is required for the function to run correctly and
when IRQ_DISABLED is set we don't know enough to do anything.
Once this is fixed we just need to fix the msi case where the
hardware doesn't provide a mask bit.
Eric
prev parent reply other threads:[~2007-02-23 6:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-23 1:21 Siddha, Suresh B
2007-02-23 6:52 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ps81wekd.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome