mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@in.ibm.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>,
	ebiederm@xmission.com, judith@linux-foundation.org,
	akpm@linux-foundation.org, fastboot@lists.osdl.org, ak@suse.de,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [Fastboot] [PATCH RFC 0/5] hard_smp_processor_id overhaul
Date: Fri, 2 Mar 2007 09:44:56 +0530	[thread overview]
Message-ID: <20070302041455.GA15386@in.ibm.com> (raw)
In-Reply-To: <20070301140648.GX26583@kvack.org>

On Thu, Mar 01, 2007 at 09:06:48AM -0500, Benjamin LaHaise wrote:
> On Thu, Mar 01, 2007 at 04:16:13PM +0900, Fernando Luis Vázquez Cao wrote:
> > As a consequence, the hardcoding of hard_smp_processor_id() to 0 on UP
> > systems (see "linux/smp.h") is not correct.
> > 
> > This patch-set does the following:
> > 
> > 1- Remove hardcoding of hard_smp_processor_id on UP systems.
> 
> NAK.  This has to be configurable, as many embedded systems don't even 
> have APICs.  Please rework the patch set so that there is not any overhead 
> for existing UP systems.

Fernando did the code audit and found no instance of hard_smp_processor_id
being used for non APIC case. So are embedded systems you are referring,
patching the kernel?

Anyway, I think providing hard_smp_processor_id() definition for UP systems
without APIC does not harm.

Thanks
Vivek

  parent reply	other threads:[~2007-03-02  4:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-01  7:16 Fernando Luis Vázquez Cao
2007-03-01 14:06 ` Benjamin LaHaise
2007-03-02  3:10   ` Fernando Luis Vázquez Cao
2007-03-02  4:14   ` Vivek Goyal [this message]
2007-03-02  8:06     ` [Fastboot] " Fernando Luis Vázquez Cao
2007-03-02  8:16       ` [PATCH] hard_smp_processor_id definition for UP systems without APIC (i386) Fernando Luis Vázquez Cao
2007-03-02  7:23 ` [Fastboot] [PATCH RFC 0/5] hard_smp_processor_id overhaul Horms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070302041455.GA15386@in.ibm.com \
    --to=vgoyal@in.ibm.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=bcrl@kvack.org \
    --cc=ebiederm@xmission.com \
    --cc=fastboot@lists.osdl.org \
    --cc=fernando@oss.ntt.co.jp \
    --cc=judith@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome