mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Roman Zippel <zippel@linux-m68k.org>,
	trivial@kernel.org
Subject: Re: [PATCH] KCONFIG: Add some extra info regarding the kernel localversion.
Date: Sun, 4 Mar 2007 22:31:28 +0100	[thread overview]
Message-ID: <20070304213128.GA26553@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0703041205530.21954@CPE00045a9c397f-CM001225dbafb6>

On Sun, Mar 04, 2007 at 12:10:18PM -0500, Robert P. J. Day wrote:
> On Sun, 4 Mar 2007, Randy Dunlap wrote:
> 
> > On Sun, 4 Mar 2007 06:01:17 -0500 (EST) Robert P. J. Day wrote:
> >
> > >
> > >   A small formatting fix, and add a few lines describing the origin of
> > > the git-based "localversion" string for the kernel version.
> > >
> > > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> > >
> > > ---
> > >
> > > diff --git a/init/Kconfig b/init/Kconfig
> > > index f977086..4d5aef6 100644
> > > --- a/init/Kconfig
> > > +++ b/init/Kconfig
> > > @@ -80,13 +80,19 @@ config LOCALVERSION_AUTO
> > >  	default y
> > >  	help
> > >  	  This will try to automatically determine if the current tree is a
> > > -	  release tree by looking for git tags that
> > > -	  belong to the current top of tree revision.
> > > +	  release tree by looking for git tags that belong to the current
> > > +	  top of tree revision.
> > >
> > >  	  A string of the format -gxxxxxxxx will be added to the localversion
> > > -	  if a git based tree is found.  The string generated by this will be
> > > +	  if a git-based tree is found.  The string generated by this will be
> > >  	  appended after any matching localversion* files, and after the value
> > > -	  set in CONFIG_LOCALVERSION
> > > +	  set in CONFIG_LOCALVERSION.  (The actual string is the first eight
> > > +	  characters produced by running the command:
> > > +
> > > +	    $ git rev-parse --verify HEAD
> > > +
> > > +	  which is done within the script "scripts/setlocalversion", in case
> > > +	  you were interested.)
> >
> > Please omit ", in case you were interested".
> 
> ok, will resubmit.
> 
> > >
> > >  	  Note: This requires Perl, and a git repository, but not necessarily
> > >  	  the git or cogito tools to be installed.
> >
> > How can this be the case since a 'git' command is used, according to
> > your new documentation?
> 
> i have no idea why that last part says that -- that's not part of my
> addition, it's the original text.  in fact, there's nothing about
> scripts/setlocalversion that seems to require perl, so that last part
> is *doubly* odd.
In the past setlocalversion was a perl script.

	Sam

      reply	other threads:[~2007-03-04 21:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-04 11:01 Robert P. J. Day
2007-03-04 16:59 ` Randy Dunlap
2007-03-04 17:10   ` Robert P. J. Day
2007-03-04 21:31     ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070304213128.GA26553@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=rpjday@mindspring.com \
    --cc=trivial@kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®