From: Dave Jiang <djiang@mvista.com>
To: linux-kernel@vger.kernel.org
Cc: ak@suse.de, trini@kernel.crashing.org, sshtylyov@ru.mvista.com
Subject: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'
Date: Wed, 7 Mar 2007 13:45:16 -0700 [thread overview]
Message-ID: <20070307204516.GA24095@blade.az.mvista.com> (raw)
The RESTORE_CONTEXT macro is missing the '\n' at the end. It was removed in the
previous patch that touched system.h. It causes compile failure if any
inline asm is added after the macro. Discovered this when playing with
kgdb.
Signed-off-by: Dave Jiang <djiang@mvista.com>
---
include/asm-x86_64/system.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/include/asm-x86_64/system.h b/include/asm-x86_64/system.h
index bd376bc..cbb8579 100644
--- a/include/asm-x86_64/system.h
+++ b/include/asm-x86_64/system.h
@@ -15,7 +15,7 @@
/* frame pointer must be last for get_wchan */
#define SAVE_CONTEXT "pushf ; pushq %%rbp ; movq %%rsi,%%rbp\n\t"
-#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\t"
+#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\n\t"
#define __EXTRA_CLOBBER \
,"rcx","rbx","rdx","r8","r9","r10","r11","r12","r13","r14","r15"
next reply other threads:[~2007-03-07 20:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 20:45 Dave Jiang [this message]
2007-03-08 17:14 ` Andi Kleen
2007-03-08 17:44 ` Dave Jiang
2007-03-08 18:37 ` Andi Kleen
2007-03-08 18:49 ` Tom Rini
2007-03-08 22:24 ` Permanent Kgdb integration into the kernel - lets get with it Piet Delaney
2007-04-17 18:30 ` Randy Dunlap
2007-04-17 18:37 ` Sergei Shtylyov
2007-04-17 18:42 ` Randy Dunlap
2007-04-17 18:45 ` Sergei Shtylyov
2007-04-17 18:45 ` Andi Kleen
2007-04-20 16:20 ` Robin Holt
2007-04-20 22:51 ` Piet Delaney
2007-04-20 23:34 ` Andrew Morton
2007-04-21 9:48 ` Andi Kleen
2007-04-24 4:02 ` Permanent Kgdb integration into the kernel - lets get with it. (Dave: How do FreeBSD folks maintain the KGDB stub?) Piet Delaney
2007-03-08 22:36 ` [PATCH] x86_64 RESTORE_CONTEXT missing '\n' Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307204516.GA24095@blade.az.mvista.com \
--to=djiang@mvista.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome