From: Andi Kleen <ak@suse.de>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Dave Jiang <djiang@mvista.com>,
linux-kernel@vger.kernel.org, sshtylyov@ru.mvista.com
Subject: Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'
Date: Thu, 8 Mar 2007 23:36:14 +0100 [thread overview]
Message-ID: <200703082336.14436.ak@suse.de> (raw)
In-Reply-To: <20070308184940.GP11626@smtp.west.cox.net>
On Thursday 08 March 2007 19:49, Tom Rini wrote:
> On Thu, Mar 08, 2007 at 07:37:56PM +0100, Andi Kleen wrote:
> > On Thursday 08 March 2007 18:44, Dave Jiang wrote:
> >
> > > In spite of kgdb, shouldn't it have that \n anyways in case some other code
> > > gets added in the future after the macro? Or are you saying that there should
> > > never be any code ever after that macro?
> >
> > Sure if there is mainline code added after that macro we add the \n.
> > But only if it makes sense to add code there, which it didn't in kgdb.
>
> Was that because with recent enough tools and config options there was
> enough annotations so GDB could finally figure out where things had
> stopped?
The x86 kernels are fully dwarf2 annotiated yes.
-Andi
prev parent reply other threads:[~2007-03-08 22:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 20:45 Dave Jiang
2007-03-08 17:14 ` Andi Kleen
2007-03-08 17:44 ` Dave Jiang
2007-03-08 18:37 ` Andi Kleen
2007-03-08 18:49 ` Tom Rini
2007-03-08 22:24 ` Permanent Kgdb integration into the kernel - lets get with it Piet Delaney
2007-04-17 18:30 ` Randy Dunlap
2007-04-17 18:37 ` Sergei Shtylyov
2007-04-17 18:42 ` Randy Dunlap
2007-04-17 18:45 ` Sergei Shtylyov
2007-04-17 18:45 ` Andi Kleen
2007-04-20 16:20 ` Robin Holt
2007-04-20 22:51 ` Piet Delaney
2007-04-20 23:34 ` Andrew Morton
2007-04-21 9:48 ` Andi Kleen
2007-04-24 4:02 ` Permanent Kgdb integration into the kernel - lets get with it. (Dave: How do FreeBSD folks maintain the KGDB stub?) Piet Delaney
2007-03-08 22:36 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703082336.14436.ak@suse.de \
--to=ak@suse.de \
--cc=djiang@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome