mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend
Date: Fri, 9 Mar 2007 23:10:22 +0100	[thread overview]
Message-ID: <20070309221022.GA1818@elf.ucw.cz> (raw)
In-Reply-To: <20070309122934.GA8412@osiris.boeblingen.de.ibm.com>

Hi!

> > ...so, if pm_ops is non-null, power_down does nonboot cpu disabling,
> > otherwise we proceed with cpus enabled?
> > 
> > That looks ugly.
> > 
> > Is the warning bogus? Or maybe we should *always* disable nonboot cpus
> > in powerdown path?
> 
> Is disable_nonboot_cpus() assuming that first_cpu(cpu_present_map) is
> the boot cpu? Just wondering why disable_nonboot_cpus() isn't using just

I'd  say so. It is nicer (and required on some APM systems?) to do
shutdown from the boot cpu.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2007-03-09 22:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-07 19:44 Rafael J. Wysocki
2007-03-07 21:07 ` Pavel Machek
2007-03-09  7:58   ` Rafael J. Wysocki
2007-03-09  8:54     ` Pavel Machek
2007-03-09 20:07       ` Rafael J. Wysocki
2007-03-09 21:07         ` Pavel Machek
2007-03-09 21:24           ` Rafael J. Wysocki
2007-03-09 22:13             ` Pavel Machek
2007-03-09 22:34               ` Rafael J. Wysocki
2007-03-09 22:48                 ` Pavel Machek
2007-03-09 12:29   ` Heiko Carstens
2007-03-09 19:39     ` Rafael J. Wysocki
2007-03-09 22:10     ` Pavel Machek [this message]
2007-03-07 21:16 ` Andrew Morton
2007-03-07 22:14   ` Rafael J. Wysocki
2007-03-07 22:19     ` Pavel Machek
2007-03-07 23:14       ` Rafael J. Wysocki
2007-03-07 22:49     ` Andrew Morton
2007-03-07 23:13       ` Rafael J. Wysocki
2007-03-08  0:20         ` Dave Jones
2007-03-08  0:48           ` Rafael J. Wysocki
2007-03-09  1:11         ` Len Brown
2007-03-09  7:11           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070309221022.GA1818@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@linux-foundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome