mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend
Date: Fri, 9 Mar 2007 23:34:00 +0100	[thread overview]
Message-ID: <200703092334.01189.rjw@sisk.pl> (raw)
In-Reply-To: <20070309221300.GB1818@elf.ucw.cz>

On Friday, 9 March 2007 23:13, Pavel Machek wrote:
> Hi!
> 
> > > > Index: linux-2.6.21-rc3/kernel/power/user.c
> > > > ===================================================================
> > > > --- linux-2.6.21-rc3.orig/kernel/power/user.c
> > > > +++ linux-2.6.21-rc3/kernel/power/user.c
> > > > @@ -402,9 +402,10 @@ static int snapshot_ioctl(struct inode *
> > > >  
> > > >  		case PMOPS_ENTER:
> > > >  			if (data->platform_suspend) {
> > > > +				disable_nonboot_cpus();
> > > >  				kernel_shutdown_prepare(SYSTEM_SUSPEND_DISK);
> > > >  				error = pm_ops->enter(PM_SUSPEND_DISK);
> > > > -				error = 0;
> > > > +				enable_nonboot_cpus();
> > > 
> > > Why did we discard return code in previous versions? Do we still want
> > > to do that?
> > 
> > I think it was a mistake.
> 
> I took a look at git-annotate, and it is yours code, so I assume you
> are right. ACK, then.

Thanks!

BTW, what about the patch at http://lkml.org/lkml/2007/3/8/363?

Rafael

  reply	other threads:[~2007-03-09 22:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-07 19:44 Rafael J. Wysocki
2007-03-07 21:07 ` Pavel Machek
2007-03-09  7:58   ` Rafael J. Wysocki
2007-03-09  8:54     ` Pavel Machek
2007-03-09 20:07       ` Rafael J. Wysocki
2007-03-09 21:07         ` Pavel Machek
2007-03-09 21:24           ` Rafael J. Wysocki
2007-03-09 22:13             ` Pavel Machek
2007-03-09 22:34               ` Rafael J. Wysocki [this message]
2007-03-09 22:48                 ` Pavel Machek
2007-03-09 12:29   ` Heiko Carstens
2007-03-09 19:39     ` Rafael J. Wysocki
2007-03-09 22:10     ` Pavel Machek
2007-03-07 21:16 ` Andrew Morton
2007-03-07 22:14   ` Rafael J. Wysocki
2007-03-07 22:19     ` Pavel Machek
2007-03-07 23:14       ` Rafael J. Wysocki
2007-03-07 22:49     ` Andrew Morton
2007-03-07 23:13       ` Rafael J. Wysocki
2007-03-08  0:20         ` Dave Jones
2007-03-08  0:48           ` Rafael J. Wysocki
2007-03-09  1:11         ` Len Brown
2007-03-09  7:11           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703092334.01189.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome