From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: kristen.c.accardi@intel.com, len.brown@intel.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: libata-acpi: allow _GTF on SATA, but disable on PATA for now
Date: Sat, 10 Mar 2007 16:40:59 +0000 [thread overview]
Message-ID: <20070310164059.4ba68bcc@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <45F296B9.7000005@garzik.org>
> Alan has been actively working on PATA ACPI, and we have been debugging
> ACPI issues as well. PLEASE coordinate with the maintainer, when
> touching code outside of drivers/acpi!
ap->cbl is not a reliable way to tell SATA from PATA at the moment. We
need to fix the real crashes too - right now no non PCI controller
actually works at all (crash on boot) because of the ACPI crap.
Please drop this patch as it will cause regressions on systems that do
not need the extra methods. Instead merge the one that fixe the non PCI
crashes and we might get further.
> AFAICS this patch went in with zero appearance on LKML or another
> related list, until submission. This is /not/ how we do Linux development.
Agreed.
NAK the patch likewise.
Alan
next prev parent reply other threads:[~2007-03-10 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200703100559.l2A5x6kP017578@hera.kernel.org>
2007-03-10 11:30 ` Jeff Garzik
2007-03-10 16:40 ` Alan Cox [this message]
2007-03-12 16:55 ` Kristen Carlson Accardi
2007-03-12 22:00 ` Alan Cox
2007-03-12 21:11 ` Kristen Carlson Accardi
2007-03-11 3:14 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070310164059.4ba68bcc@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®