mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>,
	len.brown@intel.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	IDE/ATA development list <linux-ide@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: libata-acpi: allow _GTF on SATA, but disable on PATA for now
Date: Mon, 12 Mar 2007 14:11:26 -0700	[thread overview]
Message-ID: <20070312141126.651cf967.kristen.c.accardi@intel.com> (raw)
In-Reply-To: <20070312220015.094b7759@lxorguk.ukuu.org.uk>

On Mon, 12 Mar 2007 22:00:15 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> > Meanwhile, to solve the problem for these people, and without introducing
> > a lot of new code at this stage in the release, perhaps you can suggest 
> > a more accurate way to detect PATA vs. SATA so we can fix the bug?  
> 
> I think the problem starts with the question. It supposes the BIOS knows
> the answer to the question in the first place. It also supposes we
> haven't reconfigured the port in some cases I believe.
> 
> My guess is the problem needs approaching from the other end. Ask the
> question "What does the ACPI BIOS expect it to be ?". If I follow the
> spec correctly we can answer that question by asking what methods (_SDD,
> _GTF etc) it provides.
> 
> I don't think anything else is reliable.
> 
> Alan
> 

Ah - ok, so you are saying we could query the device to see if it supports
STM/GTM and then if we were to use the workaround I suggested for this bug
we could just refuse to execute GTF on devices which support STM (since
they may require execution of STM first).  If you guys decide you want 
the workaround rather than just either disable acpi or remove the acpi patch
entirely, let me know and I'd be glad to rework it, otherwise I'm assuming
you have decided to just disable acpi all together.

  reply	other threads:[~2007-03-12 21:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200703100559.l2A5x6kP017578@hera.kernel.org>
2007-03-10 11:30 ` Jeff Garzik
2007-03-10 16:40   ` Alan Cox
2007-03-12 16:55     ` Kristen Carlson Accardi
2007-03-12 22:00       ` Alan Cox
2007-03-12 21:11         ` Kristen Carlson Accardi [this message]
2007-03-11  3:14   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070312141126.651cf967.kristen.c.accardi@intel.com \
    --to=kristen.c.accardi@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=len.brown@intel.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®