From: Oleg Nesterov <oleg@tv-sign.ru>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: + getrusage-fill-ru_inblock-and-ru_oublock-fields-if-possible.patch added to -mm tree
Date: Fri, 16 Mar 2007 20:10:23 +0300 [thread overview]
Message-ID: <20070316171023.GA218@tv-sign.ru> (raw)
Eric Dumazet wrote:
>
> @@ -2021,6 +2022,8 @@ static void k_getrusage(struct task_stru
> r->ru_nivcsw = p->signal->cnivcsw;
> r->ru_minflt = p->signal->cmin_flt;
> r->ru_majflt = p->signal->cmaj_flt;
> + r->ru_inblock = task_io_get_inblock(p);
> + r->ru_oublock = task_io_get_oublock(p);
>
> if (who == RUSAGE_CHILDREN)
> break;
> @@ -2032,6 +2035,8 @@ static void k_getrusage(struct task_stru
> r->ru_nivcsw += p->signal->nivcsw;
> r->ru_minflt += p->signal->min_flt;
> r->ru_majflt += p->signal->maj_flt;
> + r->ru_inblock += task_io_get_inblock(p);
> + r->ru_oublock += task_io_get_oublock(p);
> t = p;
> do {
> utime = cputime_add(utime, t->utime);
> @@ -2040,6 +2045,8 @@ static void k_getrusage(struct task_stru
> r->ru_nivcsw += t->nivcsw;
> r->ru_minflt += t->min_flt;
> r->ru_majflt += t->maj_flt;
> + r->ru_inblock += task_io_get_inblock(t);
> + r->ru_oublock += task_io_get_oublock(t);
I can't understand this. Consider k_getrusage(RUSAGE_BOTH). The end result
is that r->ru_inblock == 3 * task_io_get_inblock(p).
No?
Oleg.
next reply other threads:[~2007-03-16 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 17:10 Oleg Nesterov [this message]
2007-03-16 17:23 ` Eric Dumazet
2007-03-16 17:34 ` Eric Dumazet
2007-03-16 17:40 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070316171023.GA218@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®