From: Eric Dumazet <dada1@cosmosbay.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: + getrusage-fill-ru_inblock-and-ru_oublock-fields-if-possible.patch added to -mm tree
Date: Fri, 16 Mar 2007 18:34:23 +0100 [thread overview]
Message-ID: <200703161834.23901.dada1@cosmosbay.com> (raw)
In-Reply-To: <200703161823.57858.dada1@cosmosbay.com>
On Friday 16 March 2007 18:23, Eric Dumazet wrote:
>
> Very good point, you found a bug in k_getrusage().
>
> I just followed the existing logic, but it seems this logic is bad.
>
> So not only ru_inblock/ru_oublock are multiplied by 3 : others fields as
> well are wrong.
>
> Also the definition of RUSAGE_CHILDREN is not conformant to standard
>
> http://www.opengroup.org/onlinepubs/009695399/functions/getrusage.html
>
> "If the value of the who argument is RUSAGE_CHILDREN, information shall be
> "returned about resources used by the terminated and waited-for children
> of "the current process
>
> We currently do a sum of rusage stats of still alive children.. thats
> totally wrong...
Please ignore this mail, I was very wrong.
I shall rethink a proper patch.
next prev parent reply other threads:[~2007-03-16 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 17:10 Oleg Nesterov
2007-03-16 17:23 ` Eric Dumazet
2007-03-16 17:34 ` Eric Dumazet [this message]
2007-03-16 17:40 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703161834.23901.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®