From: Jesper Juhl <jesper.juhl@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Andi Kleen <ak@suse.de>,
Trent Waddington <trent.waddington@gmail.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH][2/5][resend] floppy.c: Remove pointless register keywords
Date: Mon, 19 Mar 2007 16:10:29 +0100 [thread overview]
Message-ID: <200703191610.30571.jesper.juhl@gmail.com> (raw)
This patch removes the use of the 'register' keyword from floppy.c
Marking some variables 'register' may have made sense in the past (though I
doubt it for these ones), but these days I very much suspect that we would
rather grant gcc more freedom in how to handle the variables and I doubt
very much that in this day and age optimizing access to variables via
'register' makes any sense for a floppy driver. Let's just get rid of it.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 5da54b8..dea7c4f 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -791,7 +791,7 @@ static inline int is_selected(int dor, int unit)
static int set_dor(int fdc, char mask, char data)
{
- register unsigned char drive, unit, newdor, olddor;
+ unsigned char drive, unit, newdor, olddor;
if (FDCS->address == -1)
return -1;
@@ -946,7 +946,7 @@ static void motor_off_callback(unsigned long nr)
static void floppy_off(unsigned int drive)
{
unsigned long volatile delta;
- register int fdc = FDC(drive);
+ int fdc = FDC(drive);
if (!(FDCS->dor & (0x10 << UNIT(drive))))
return;
reply other threads:[~2007-03-19 15:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703191610.30571.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trent.waddington@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®