mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH][2/5][resend] floppy.c: Remove pointless register keywords
@ 2007-03-19 15:10 Jesper Juhl
  0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2007-03-19 15:10 UTC (permalink / raw)
  To: Andrew Morton
  Cc: LKML, Andi Kleen, Trent Waddington, Bartlomiej Zolnierkiewicz,
	Alan Cox, Jesper Juhl


    This patch removes the use of the 'register' keyword from floppy.c
    
    Marking some variables 'register' may have made sense in the past (though I
    doubt it for these ones), but these days I very much suspect that we would
    rather grant gcc more freedom in how to handle the variables and I doubt
    very much that in this day and age optimizing access to variables via
    'register' makes any sense for a floppy driver.  Let's just get rid of it.
    
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 5da54b8..dea7c4f 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -791,7 +791,7 @@ static inline int is_selected(int dor, int unit)
 
 static int set_dor(int fdc, char mask, char data)
 {
-	register unsigned char drive, unit, newdor, olddor;
+	unsigned char drive, unit, newdor, olddor;
 
 	if (FDCS->address == -1)
 		return -1;
@@ -946,7 +946,7 @@ static void motor_off_callback(unsigned long nr)
 static void floppy_off(unsigned int drive)
 {
 	unsigned long volatile delta;
-	register int fdc = FDC(drive);
+	int fdc = FDC(drive);
 
 	if (!(FDCS->dor & (0x10 << UNIT(drive))))
 		return;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-03-19 15:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-19 15:10 [PATCH][2/5][resend] floppy.c: Remove pointless register keywords Jesper Juhl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®