From: Andrew Morton <akpm@linux-foundation.org>
To: David Brownell <david-b@pacbell.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.21-rc5] arch/x86_64/kernel/early-quirks.c compiler warning
Date: Mon, 26 Mar 2007 15:05:23 -0700 [thread overview]
Message-ID: <20070326150523.b748b44b.akpm@linux-foundation.org> (raw)
In-Reply-To: <200703260917.44906.david-b@pacbell.net>
On Mon, 26 Mar 2007 09:17:44 -0700
David Brownell <david-b@pacbell.net> wrote:
> Fix "unused variable" compiler warning on non-SMP x86_64 configs.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> --- a/arch/x86_64/kernel/early-quirks.c
> +++ b/arch/x86_64/kernel/early-quirks.c
> @@ -73,9 +73,9 @@ static void __init ati_bugs(void)
>
> static void intel_bugs(void)
> {
> +#ifdef CONFIG_SMP
> u16 device = read_pci_config_16(0, 0, 0, PCI_DEVICE_ID);
>
> -#ifdef CONFIG_SMP
> if (device == PCI_DEVICE_ID_INTEL_E7320_MCH ||
> device == PCI_DEVICE_ID_INTEL_E7520_MCH ||
> device == PCI_DEVICE_ID_INTEL_E7525_MCH)
This whole function gets removed by
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt-current/patches/revert-x86_64-mm-fix-the-irqbalance-quirk-for-e7320-e7520-e7525
so I think I'll duck the patch. Which is very bad of me, because it means
2.6.21 goes out with this warning. But I don't think many people build
non-SMP x86_64.
prev parent reply other threads:[~2007-03-26 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 16:17 David Brownell
2007-03-26 22:05 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070326150523.b748b44b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome