* [patch 2.6.21-rc5] arch/x86_64/kernel/early-quirks.c compiler warning
@ 2007-03-26 16:17 David Brownell
2007-03-26 22:05 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: David Brownell @ 2007-03-26 16:17 UTC (permalink / raw)
To: Linux Kernel list; +Cc: akpm
Fix "unused variable" compiler warning on non-SMP x86_64 configs.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
--- a/arch/x86_64/kernel/early-quirks.c
+++ b/arch/x86_64/kernel/early-quirks.c
@@ -73,9 +73,9 @@ static void __init ati_bugs(void)
static void intel_bugs(void)
{
+#ifdef CONFIG_SMP
u16 device = read_pci_config_16(0, 0, 0, PCI_DEVICE_ID);
-#ifdef CONFIG_SMP
if (device == PCI_DEVICE_ID_INTEL_E7320_MCH ||
device == PCI_DEVICE_ID_INTEL_E7520_MCH ||
device == PCI_DEVICE_ID_INTEL_E7525_MCH)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch 2.6.21-rc5] arch/x86_64/kernel/early-quirks.c compiler warning 2007-03-26 16:17 [patch 2.6.21-rc5] arch/x86_64/kernel/early-quirks.c compiler warning David Brownell @ 2007-03-26 22:05 ` Andrew Morton 0 siblings, 0 replies; 2+ messages in thread From: Andrew Morton @ 2007-03-26 22:05 UTC (permalink / raw) To: David Brownell; +Cc: Linux Kernel list On Mon, 26 Mar 2007 09:17:44 -0700 David Brownell <david-b@pacbell.net> wrote: > Fix "unused variable" compiler warning on non-SMP x86_64 configs. > > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> > > --- a/arch/x86_64/kernel/early-quirks.c > +++ b/arch/x86_64/kernel/early-quirks.c > @@ -73,9 +73,9 @@ static void __init ati_bugs(void) > > static void intel_bugs(void) > { > +#ifdef CONFIG_SMP > u16 device = read_pci_config_16(0, 0, 0, PCI_DEVICE_ID); > > -#ifdef CONFIG_SMP > if (device == PCI_DEVICE_ID_INTEL_E7320_MCH || > device == PCI_DEVICE_ID_INTEL_E7520_MCH || > device == PCI_DEVICE_ID_INTEL_E7525_MCH) This whole function gets removed by ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt-current/patches/revert-x86_64-mm-fix-the-irqbalance-quirk-for-e7320-e7520-e7525 so I think I'll duck the patch. Which is very bad of me, because it means 2.6.21 goes out with this warning. But I don't think many people build non-SMP x86_64. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-26 22:05 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2007-03-26 16:17 [patch 2.6.21-rc5] arch/x86_64/kernel/early-quirks.c compiler warning David Brownell 2007-03-26 22:05 ` Andrew Morton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome