mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg K-H <greg@kroah.com>
Cc: WANG Cong <xiyou.wangcong@gmail.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	viro@zeniv.linux.org.uk
Subject: [Patch -mm] kobject: kobject_add() reference leak
Date: Tue, 10 Apr 2007 14:35:27 +0200	[thread overview]
Message-ID: <20070410143527.2b7718b8@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20070410143106.03d62e7c@gondolin.boeblingen.de.ibm.com>

<This patch is the "pathological case" in the referenced mail.>

We leak a reference if we attempt to add a kobject with no name.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>

---
 lib/kobject.c |    1 +
 1 files changed, 1 insertion(+)

--- linux-2.6.21-rc6-mm1.orig/lib/kobject.c
+++ linux-2.6.21-rc6-mm1/lib/kobject.c
@@ -218,6 +218,7 @@ int kobject_shadow_add(struct kobject * 
 	if (!*kobj->k_name) {
 		pr_debug("kobject attempted to be registered with no name!\n");
 		WARN_ON(1);
+		kobject_put(kobj);
 		return -EINVAL;
 	}
 	parent = kobject_get(kobj->parent);

  reply	other threads:[~2007-04-10 12:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-01  7:32 [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc Cong WANG
2007-04-02 11:01 ` Cornelia Huck
2007-04-05  4:54   ` WANG Cong
2007-04-05  9:11     ` Cornelia Huck
2007-04-05 14:44       ` WANG Cong
2007-04-05 15:05         ` Cornelia Huck
2007-04-05 15:27           ` WANG Cong
2007-04-05 16:00             ` Cornelia Huck
2007-04-06  2:53               ` WANG Cong
2007-04-10 12:31                 ` Cornelia Huck
2007-04-10 12:35                   ` Cornelia Huck [this message]
2007-04-10 14:08                   ` WANG Cong
2007-04-10 22:18                     ` Andrew Morton
2007-04-11  6:45                       ` WANG Cong
2007-04-11  7:19                         ` Andrew Morton
2007-04-11  9:24                       ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070410143527.2b7718b8@gondolin.boeblingen.de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®